Fix subscribing/fetching objects not in the default partition#17581
Merged
andrewstucki merged 2 commits intomainfrom Jun 6, 2023
Merged
Fix subscribing/fetching objects not in the default partition#17581andrewstucki merged 2 commits intomainfrom
andrewstucki merged 2 commits intomainfrom
Conversation
andrewstucki
added
theme/api-gw
2 tasks
andrewstucki
changed the title
t-eckert
approved these changes
Jun 6, 2023
This was referenced Jun 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We had a bug where we weren't correctly fetching config entries that were in alternative partitions, so if a gateway was in a non-default partition, we wouldn't reconcile it properly. I discovered this writing an acceptance test in
consul-k8sthat spins up gateways in alternative partitions and vetted this on enterprise.PR Checklist