Skip to content

Backport of NET-5371 License checker pt2 into release/1.16.x#18495

Merged
hc-github-team-consul-core merged 2 commits intorelease/1.16.xfrom
backport/license-checker-pt2/vigorously-fun-swine
Aug 16, 2023
Merged

Backport of NET-5371 License checker pt2 into release/1.16.x#18495
hc-github-team-consul-core merged 2 commits intorelease/1.16.xfrom
backport/license-checker-pt2/vigorously-fun-swine

Conversation

@hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #18491 to be assessed for backporting due to the inclusion of the label backport/1.16.

The below text is copied from the body of the original PR.


Description

I created a test PR (#18486) after merging this action originally in #18485 and realized that grep behaves differently in ubuntu:latest than it does in MacOS.

This updates to use a format that works in Ubuntu and runs the action whenever new commits are pushed to a backport PR instead of just when it's initially opened.

Testing & Reproduction steps

Ran script in an Ubuntu docker container

$ docker run -it ubuntu:latest /bin/sh
$ apt update && apt install git
$ git clone https://github.com/hashicorp/consul
$ cd consul
$ ./.github/scripts/license_checker.sh
# Observe failure because many files have the BUSL header
$ git checkout release/1.15.x
$ git checkout license-checker-pt2 -- .github/scripts/license_checker.sh
$ ./.github/scripts/license_checker.sh
# Observe success because no files have the BUSL header

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/license-checker-pt2/vigorously-fun-swine branch from c7a3257 to 96b9131 Compare August 16, 2023 20:48
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/license-checker-pt2/vigorously-fun-swine branch from 6bd8d5c to e979707 Compare August 16, 2023 20:48
@github-actions github-actions bot added type/ci Relating to continuous integration (CI) tooling for testing or releases theme/contributing Additions and enhancements to community contributing materials labels Aug 16, 2023
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@vercel vercel bot temporarily deployed to Preview – consul-ui-staging August 16, 2023 20:51 Inactive
@vercel vercel bot temporarily deployed to Preview – consul August 16, 2023 20:53 Inactive
@hc-github-team-consul-core hc-github-team-consul-core merged commit 720ba94 into release/1.16.x Aug 16, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/license-checker-pt2/vigorously-fun-swine branch August 16, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme/contributing Additions and enhancements to community contributing materials type/ci Relating to continuous integration (CI) tooling for testing or releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants