-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Habitat Rearrange tasks + Bug fixes use due to bad default initial poses #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StoneT2000
requested changes
Aug 28, 2024
mani_skill/utils/scene_builder/replicacad/rearrange/scene_builder.py
Outdated
Show resolved
Hide resolved
arth-shukla
requested review from
StoneT2000
and removed request for
StoneT2000
October 8, 2024 19:03
ok changes are good, just run and fix the errors that occur in the test (you can ignore any of the ones that complain about not enough gpu mem) |
StoneT2000
requested changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests
arth-shukla
force-pushed
the
scene_manip
branch
from
October 12, 2024 05:58
85e42ec
to
6bf6754
Compare
only some remaining errors on unrelated tests
|
StoneT2000
changed the title
Scene manip
[Feature] Habitat Rearrange tasks + Reduce memory use due to bad default initial poses
Oct 14, 2024
StoneT2000
changed the title
[Feature] Habitat Rearrange tasks + Reduce memory use due to bad default initial poses
[Feature] Habitat Rearrange tasks + Bug fixes use due to bad default initial poses
Oct 14, 2024
StoneT2000
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actor/articulation building
scene builders/manip
misc