[BugFix] Fix OpenCabinetDrawer-v1 #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change from #529 now ensure all objects created will have different initial poses on the GPU to ensure they definitely do not clash upon creating the objects. This actually fixes a bug in the articulated envs since the cabinets would open randomly but that was because during GPU init the robot collides with the cabinets since neither's initial pose has been set and so they default to the origin.
However this also means the collision mesh bounding box is now shifted unless the initial pose of the cabinet is set correctly.
Anyway it is now highly recommended in the docs to set initial poses of objects during loading to places you know they won't collide. Otherwise our code attempts to do it for you.