[v15]: Backport the new wizard for adding authentication devices#38535
Merged
bl-nero merged 5 commits intobranch/v15from Feb 23, 2024
Merged
[v15]: Backport the new wizard for adding authentication devices#38535bl-nero merged 5 commits intobranch/v15from
bl-nero merged 5 commits intobranch/v15from
Conversation
* Add an option to enable a new Add Device dialog design Also deduplicate code from storageService functions that parse JSON. * lint
* A wizard for adding authentication devices * Hide changes between localStorage flag * Review
* Add capability of adding MFA to the new auth device wizard * Review * Review * License
* Add capability of adding MFA to the new auth device wizard * Review * Review * Make the auth device wizard look pretty * License * Review * Fix lint
…#38393) * Remove the old AddDevice dialog Also cleans up the accompanying local storage flag. * Rename `canAddMFA` Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> * Update a success message Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> * review * Review --------- Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
Contributor
Author
|
@avatus To test it, please go to the account settings screen and try adding passkeys and MFA devices. Make sure that you can verify your identity using various methods. Corner cases:
|
Contributor
|
I tested as many paths as I could think of and didn't run into anything that seemed out of the ordinary. So, LGTM. a couple things that errored for me (but i believe are expected and/or my fault)
|
avatus
approved these changes
Feb 22, 2024
Contributor
Author
|
Thank you, @avatus!
Yeah, we have never supported this scenario in any way other than relying on internal processes in users' organizations.
That's a good point. I'll look into it, but my gut says it's not worth changing the data model constraints just because of this. |
gzdunek
approved these changes
Feb 23, 2024
Contributor
gzdunek
left a comment
gzdunek
left a comment
There was a problem hiding this comment.
I haven't tested it and only went over the commits, everything appears to be fine.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a combined backport of the following pull requests:
There was 1 conflict to resolve - between #38393 and #37743. The conflict appeared in the code that is being removed, as the conflicting PR was a bugfix on the old dialog. The conflict was resolved by removing the file.
Do not submit until tested by @avatus.
Contributes to #37616
Changelog: Updated the dialog for adding new authentication methods in the account settings screen.