Add an option to enable a new Add Device dialog design#37747
Merged
Conversation
Also deduplicate code from storageService functions that parse JSON.
bl-nero
added
the
no-changelog
rudream
approved these changes
Feb 5, 2024
zmb3
approved these changes
Feb 5, 2024
Collaborator
zmb3
left a comment
zmb3
left a comment
There was a problem hiding this comment.
Looks fine but is it really necessary?
public-teleport-github-review-bot
Bot
removed the request for review
from kimlisa
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
bl-nero
added a commit
that referenced
this pull request
Feb 22, 2024
* Add an option to enable a new Add Device dialog design Also deduplicate code from storageService functions that parse JSON. * lint
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 23, 2024
) * Add an option to enable a new Add Device dialog design (#37747) * Add an option to enable a new Add Device dialog design Also deduplicate code from storageService functions that parse JSON. * lint * A wizard for adding authentication devices (#38100) * A wizard for adding authentication devices * Hide changes between localStorage flag * Review * Add capability of adding MFA to the new auth device wizard (#38260) * Add capability of adding MFA to the new auth device wizard * Review * Review * License * Make the auth device wizard look pretty (#38353) * Add capability of adding MFA to the new auth device wizard * Review * Review * Make the auth device wizard look pretty * License * Review * Fix lint * Remove the old AddDevice dialog and substitute it with the new wizard (#38393) * Remove the old AddDevice dialog Also cleans up the accompanying local storage flag. * Rename `canAddMFA` Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> * Update a success message Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> * review * Review --------- Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> --------- Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also deduplicate code from storageService functions that parse JSON.
Contributes to #37616