Remove the old AddDevice dialog and substitute it with the new wizard#38393
Remove the old AddDevice dialog and substitute it with the new wizard#38393
Conversation
Also cleans up the accompanying local storage flag.
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
| ${'on'} | ${false} | ${false} | ${true} | ||
| ${'optional'} | ${true} | ${true} | ${true} | ||
| ${'optional'} | ${false} | ${false} | ${true} | ||
| ${'otp'} | ${true} | ${false} | ${true} |
There was a problem hiding this comment.
Why was this test case removed?
There was a problem hiding this comment.
@zmb3 It got broken when I removed a redundant check, but it's also impossible in real life: the OTP option implies passwordless being disabled. The auth server refuses to start if these options are in conflict. Similarly, we don't check what happens if 2fa is set to "off" and passwordless is set to true.
If you still think it's good to check these seemingly impossible conditions, I can bring back this case (and extend the "off" case) to verify that we always enable passwordless when the backend tells us so, regardless of the MFA setting itself.
There was a problem hiding this comment.
(On the second thought, I just went on and included these anyway.)
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
|
Looking good. The only issue I noticed is that I can't remove a passkey, even though I have other non-passwordless methods for logging in. 
(This is also not a great UX, because the dialog continues to show me a "remove" button over and over again, but attempts to click it will always fail with the same outcome) |
Filed #38433 for it, as this is not something introduced by this PR. |
| isSso={isSso} | ||
| canAddPasskeys={canAddPasskeys} | ||
| canAddMFA={canAddMFA} | ||
| canAddMFA={canAddMfa} |
There was a problem hiding this comment.
Nit: we can change it here as well:
| canAddMFA={canAddMfa} | |
| canAddMfa={canAddMfa} |
public-teleport-github-review-bot
Bot
removed the request for review
from ryanclark
…#38393) * Remove the old AddDevice dialog Also cleans up the accompanying local storage flag. * Rename `canAddMFA` Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> * Update a success message Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> * review * Review --------- Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
) * Add an option to enable a new Add Device dialog design (#37747) * Add an option to enable a new Add Device dialog design Also deduplicate code from storageService functions that parse JSON. * lint * A wizard for adding authentication devices (#38100) * A wizard for adding authentication devices * Hide changes between localStorage flag * Review * Add capability of adding MFA to the new auth device wizard (#38260) * Add capability of adding MFA to the new auth device wizard * Review * Review * License * Make the auth device wizard look pretty (#38353) * Add capability of adding MFA to the new auth device wizard * Review * Review * Make the auth device wizard look pretty * License * Review * Fix lint * Remove the old AddDevice dialog and substitute it with the new wizard (#38393) * Remove the old AddDevice dialog Also cleans up the accompanying local storage flag. * Rename `canAddMFA` Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> * Update a success message Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> * review * Review --------- Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> --------- Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
4 participants
Fixes #37616
Changelog: Updated the dialog for adding new authentication methods in the account settings screen.