A wizard for adding authentication devices#38100
Conversation
bl-nero
added
the
no-changelog
zmb3
left a comment
zmb3
left a comment
There was a problem hiding this comment.
Code and tests look good, but I'm not sure we should merge this until the styling is fixed. It's a relatively small PR as-is, and by merging what you have here we introduce a chance that we fail to backport styling updates and show users a set of screens that look half done.
@zmb3 Good catch, I forgot to put this change behind the flag that I prepared last week. Fixed it (it was just one statement that triggers the flow; the rest of the logic just lives there in parallel). The thing is, I'd still like to push this change through, since it's sizable enough, and I'd like to first integrate both passkeys and MFAs to the new flow, and only then work on the styling details. |
gzdunek
left a comment
gzdunek
left a comment
There was a problem hiding this comment.
Looks good, I left some code-style comments.
|
@gzdunek FYI, I decided to leave the error message in the backend as it is, since it's consistent with CLI, and instead translate it in the UI code (and clearly mark dependencies on both sides so it's visible where we depend on it). |
* A wizard for adding authentication devices * Hide changes between localStorage flag * Review
) * Add an option to enable a new Add Device dialog design (#37747) * Add an option to enable a new Add Device dialog design Also deduplicate code from storageService functions that parse JSON. * lint * A wizard for adding authentication devices (#38100) * A wizard for adding authentication devices * Hide changes between localStorage flag * Review * Add capability of adding MFA to the new auth device wizard (#38260) * Add capability of adding MFA to the new auth device wizard * Review * Review * License * Make the auth device wizard look pretty (#38353) * Add capability of adding MFA to the new auth device wizard * Review * Review * Make the auth device wizard look pretty * License * Review * Fix lint * Remove the old AddDevice dialog and substitute it with the new wizard (#38393) * Remove the old AddDevice dialog Also cleans up the accompanying local storage flag. * Rename `canAddMFA` Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> * Update a success message Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> * review * Review --------- Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> --------- Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
4 participants
Contributes to #36232
Contributes to #37616
This is a first pass at implementing the new designs. This PR covers all of the logic and interactions needed for the passkey dialog. Follow-up PRs will address layout and styling, as well as adding MFAs.
Figma designs
Demo