Don't submit add device form through the browser if validation fails#37743
Merged
Don't submit add device form through the browser if validation fails#37743
Conversation
bl-nero
added
no-changelog
zmb3
approved these changes
Feb 5, 2024
Collaborator
|
This one can probably be backported all the way to 13. |
avatus
approved these changes
Feb 5, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from gzdunek
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31350
Note: I'm not adding any unit test for 2 reasons:
HTMLFormElement.prototype, but no luck. The jsdom code goes straight to some internals that are not easily accessible.Tested manually instead using a passkey, a MFA token, and an authenticator app.
Demo: https://www.loom.com/share/3fa1983639a341d1b36be0a03bbc678c