Skip to content

[v13] chore: Update Go toolchain to 1.21.6#37561

Merged
codingllama merged 6 commits intobranch/v13from
codingllama/go121-v13
Feb 5, 2024
Merged

[v13] chore: Update Go toolchain to 1.21.6#37561
codingllama merged 6 commits intobranch/v13from
codingllama/go121-v13

Conversation

@codingllama
Copy link
Copy Markdown
Contributor

@codingllama codingllama commented Jan 30, 2024 •
edited by camscale
Loading

Update the Go toolchain in preparation for Go 1.22 (and, consequently, the Go 1.20 EOL).

Backports, to various degrees, #30180, #30201, #30525 and #31505.

Changelog: Updated Go to 1.21.6.

codingllama and others added 5 commits January 30, 2024 17:45
@codingllama
chore: Bump Go to v1.21.0 (#30180)
0e19ff1 
* chore: Bump Go to 1.21.0

* Run `make dronegen`

* Bump .golangci.yml version

* Bump docs/config.json version

* Update e/ reference
@jakule @codingllama
Fix test after Go 1.21 upgrade (#30201)
8ccbef7 
* Fix test after Go 1.21 upgrade

Updated the error messages in the lib/teleterm/teleterm_test.go and lib/auth/tls_test.go test files from "tls: bad certificate" to more specific ones ("tls: certificate required", "unknown certificate authority") to accurately reflect the Go 1.21 update in the TLS server behavior.

* Apply suggestions from code review

Co-authored-by: Alan Parra <alan.parra@goteleport.com>

---------

Co-authored-by: Alan Parra <alan.parra@goteleport.com>
@jakule @codingllama
Update TLS configuration in auth helpers (#30525)
16295bf 
Removed the line that disables Session Tickets (added after Go 1.21 upgrade) to restore the default behavior of TLS servers. It looks like this change introduced a flakiness in a few tests.
@codingllama
chore: Bump Go to 1.21.1 (#31505) (partial)
e230be3 
* Don't attempt to use Go 1.19 in the root module

* Use Go 1.21 on grpcbox

* Bump Go to 1.21.1

* Bump Go toolchain to go1.21.1

* Run `make dronegen`
@codingllama
Bump Go toolchain to 1.21.6
898da02
@github-actions github-actions Bot requested review from jakule and mdwn January 30, 2024 21:03
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 30, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 30, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@codingllama
Copy link
Copy Markdown
Contributor Author

codingllama commented Jan 30, 2024

Looking back at the history I think this is it. I'm not touching go.mod files as it looks like we'll need a new buildbox first.

I'm not getting any changes when running make dronegen, let me know if that isn't correct.

e/ PR soon to follow.

@rosstimothy
Copy link
Copy Markdown
Contributor

rosstimothy commented Jan 31, 2024

Let's hold off on merging this until we can get a v13 build out with go1.21 and run a few smoke tests

rosstimothy
rosstimothy approved these changes Feb 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@rosstimothy rosstimothy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran a few smoke tests and a smaller scaling test and things seemed alright. 🚢

@codingllama
Copy link
Copy Markdown
Contributor Author

codingllama commented Feb 5, 2024

Could I have a .github/workflows approval? @zmb3, @r0mant, @fheinecke, @camscale or @tcsc?

@codingllama codingllama enabled auto-merge February 5, 2024 16:54
@codingllama codingllama added this pull request to the merge queue Feb 5, 2024
Merged via the queue into branch/v13 with commit 4b046e5 Feb 5, 2024
@codingllama codingllama deleted the codingllama/go121-v13 branch February 5, 2024 17:10
@codingllama codingllama mentioned this pull request Feb 5, 2024
Closed
@camscale camscale mentioned this pull request Feb 6, 2024
Merged
This was referenced Feb 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@r0mant r0mant r0mant approved these changes

@zmb3 zmb3 zmb3 approved these changes

@rosstimothy rosstimothy rosstimothy approved these changes

@klizhentas klizhentas Awaiting requested review from klizhentas klizhentas is a code owner

@russjones russjones Awaiting requested review from russjones russjones is a code owner

@fheinecke fheinecke Awaiting requested review from fheinecke fheinecke is a code owner

@camscale camscale Awaiting requested review from camscale camscale is a code owner

@tcsc tcsc Awaiting requested review from tcsc tcsc is a code owner

+2 more reviewers

@mdwn mdwn mdwn approved these changes

@jakule jakule jakule approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport documentation size/sm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@codingllama @rosstimothy @r0mant @mdwn @zmb3 @jakule