Skip to content

chore: Bump Go to v1.21.0#30180

Merged
codingllama merged 5 commits intomasterfrom
codingllama/bump-go
Aug 8, 2023
Merged

chore: Bump Go to v1.21.0#30180
codingllama merged 5 commits intomasterfrom
codingllama/bump-go

Conversation

@codingllama
Copy link
Copy Markdown
Contributor

@codingllama codingllama commented Aug 8, 2023

Update Go toolchain to the latest release.

Changelog: Update Go to 1.21.0.

@github-actions github-actions Bot requested review from mdwn and probakowski August 8, 2023 16:18
Comment thread build.assets/Makefile Outdated
@codingllama
Copy link
Copy Markdown
Contributor Author

Building the new buildbox and verifying effects on golangci-lint right now. I've been the running the RC since it's out so I don't think we'll see any issues.

@codingllama codingllama force-pushed the codingllama/bump-go branch from 4bafcf6 to 26fe0be Compare August 8, 2023 16:42
@codingllama
Copy link
Copy Markdown
Contributor Author

Buildbox and golangci looking OK, as are the tests. I've decided to let loopvar out for this first PR, we can consider how to exercise it later.

Let me know if I forgot anything else.

@mdwn
Copy link
Copy Markdown
Contributor

mdwn commented Aug 8, 2023

How about go.mod as well?

@codingllama
Copy link
Copy Markdown
Contributor Author

How about go.mod as well?

I don't want to bump the module version, just the toolchain. There are larger effects to bumping the module itself, for example what happens with backports/existing releases.

@codingllama codingllama requested review from rosstimothy and removed request for probakowski August 8, 2023 16:45
@codingllama
Copy link
Copy Markdown
Contributor Author

Friendly ping @zmb3 ?

@codingllama codingllama enabled auto-merge August 8, 2023 17:25
@codingllama codingllama added this pull request to the merge queue Aug 8, 2023
@codingllama codingllama removed this pull request from the merge queue due to a manual request Aug 8, 2023
@codingllama codingllama force-pushed the codingllama/bump-go branch from 26fe0be to e564142 Compare August 8, 2023 17:26
@codingllama
Copy link
Copy Markdown
Contributor Author

e/ update just landed, so I've snuck it in as well.

@codingllama codingllama enabled auto-merge August 8, 2023 17:26
@codingllama codingllama added this pull request to the merge queue Aug 8, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 8, 2023
@codingllama codingllama added this pull request to the merge queue Aug 8, 2023
Merged via the queue into master with commit 600d145 Aug 8, 2023
@codingllama codingllama deleted the codingllama/bump-go branch August 8, 2023 18:14
codingllama added a commit that referenced this pull request Aug 8, 2023
codingllama added a commit that referenced this pull request Aug 14, 2023
github-merge-queue Bot pushed a commit that referenced this pull request Aug 14, 2023
* Revert "chore: Bump Go to v1.21.0 (#30180)"

This reverts commit 600d145.

* Revert Go on versions.mk

* Keep current e/ reference
codingllama added a commit that referenced this pull request Jan 30, 2024
* chore: Bump Go to 1.21.0

* Run `make dronegen`

* Bump .golangci.yml version

* Bump docs/config.json version

* Update e/ reference
github-merge-queue Bot pushed a commit that referenced this pull request Feb 5, 2024
* chore: Bump Go to v1.21.0 (#30180)

* chore: Bump Go to 1.21.0

* Run `make dronegen`

* Bump .golangci.yml version

* Bump docs/config.json version

* Update e/ reference

* Fix test after Go 1.21 upgrade (#30201)

* Fix test after Go 1.21 upgrade

Updated the error messages in the lib/teleterm/teleterm_test.go and lib/auth/tls_test.go test files from "tls: bad certificate" to more specific ones ("tls: certificate required", "unknown certificate authority") to accurately reflect the Go 1.21 update in the TLS server behavior.

* Apply suggestions from code review

Co-authored-by: Alan Parra <alan.parra@goteleport.com>

---------

Co-authored-by: Alan Parra <alan.parra@goteleport.com>

* Update TLS configuration in auth helpers (#30525)

Removed the line that disables Session Tickets (added after Go 1.21 upgrade) to restore the default behavior of TLS servers. It looks like this change introduced a flakiness in a few tests.

* chore: Bump Go to 1.21.1 (#31505) (partial)

* Don't attempt to use Go 1.19 in the root module

* Use Go 1.21 on grpcbox

* Bump Go to 1.21.1

* Bump Go toolchain to go1.21.1

* Run `make dronegen`

* Bump Go toolchain to 1.21.6

* Update e/ reference

---------

Co-authored-by: Jakub Nyckowski <jakub.nyckowski@goteleport.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants