Fix test after Go 1.21 upgrade#30201
Merged
GavinFrazar merged 2 commits intomasterfrom Aug 9, 2023
Merged
Conversation
Updated the error messages in the lib/teleterm/teleterm_test.go and lib/auth/tls_test.go test files from "tls: bad certificate" to more specific ones ("tls: certificate required", "unknown certificate authority") to accurately reflect the Go 1.21 update in the TLS server behavior.
zmb3
approved these changes
Aug 8, 2023
tigrato
approved these changes
Aug 8, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from codingllama
codingllama
approved these changes
Aug 8, 2023
Contributor
|
Note: fixes breakages introduced by #30180. |
Co-authored-by: Alan Parra <alan.parra@goteleport.com>
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
codingllama
added a commit
that referenced
this pull request
Jan 30, 2024
* Fix test after Go 1.21 upgrade
Updated the error messages in the lib/teleterm/teleterm_test.go and lib/auth/tls_test.go test files from "tls: bad certificate" to more specific ones ("tls: certificate required", "unknown certificate authority") to accurately reflect the Go 1.21 update in the TLS server behavior.
* Apply suggestions from code review
Co-authored-by: Alan Parra <alan.parra@goteleport.com>
---------
Co-authored-by: Alan Parra <alan.parra@goteleport.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 5, 2024
* chore: Bump Go to v1.21.0 (#30180) * chore: Bump Go to 1.21.0 * Run `make dronegen` * Bump .golangci.yml version * Bump docs/config.json version * Update e/ reference * Fix test after Go 1.21 upgrade (#30201) * Fix test after Go 1.21 upgrade Updated the error messages in the lib/teleterm/teleterm_test.go and lib/auth/tls_test.go test files from "tls: bad certificate" to more specific ones ("tls: certificate required", "unknown certificate authority") to accurately reflect the Go 1.21 update in the TLS server behavior. * Apply suggestions from code review Co-authored-by: Alan Parra <alan.parra@goteleport.com> --------- Co-authored-by: Alan Parra <alan.parra@goteleport.com> * Update TLS configuration in auth helpers (#30525) Removed the line that disables Session Tickets (added after Go 1.21 upgrade) to restore the default behavior of TLS servers. It looks like this change introduced a flakiness in a few tests. * chore: Bump Go to 1.21.1 (#31505) (partial) * Don't attempt to use Go 1.19 in the root module * Use Go 1.21 on grpcbox * Bump Go to 1.21.1 * Bump Go toolchain to go1.21.1 * Run `make dronegen` * Bump Go toolchain to 1.21.6 * Update e/ reference --------- Co-authored-by: Jakub Nyckowski <jakub.nyckowski@goteleport.com>
codingllama
added a commit
that referenced
this pull request
Feb 9, 2024
* Fix test after Go 1.21 upgrade
Updated the error messages in the lib/teleterm/teleterm_test.go and lib/auth/tls_test.go test files from "tls: bad certificate" to more specific ones ("tls: certificate required", "unknown certificate authority") to accurately reflect the Go 1.21 update in the TLS server behavior.
* Apply suggestions from code review
Co-authored-by: Alan Parra <alan.parra@goteleport.com>
---------
Co-authored-by: Alan Parra <alan.parra@goteleport.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 9, 2024
* Fix test after Go 1.21 upgrade
Updated the error messages in the lib/teleterm/teleterm_test.go and lib/auth/tls_test.go test files from "tls: bad certificate" to more specific ones ("tls: certificate required", "unknown certificate authority") to accurately reflect the Go 1.21 update in the TLS server behavior.
* Apply suggestions from code review
---------
Co-authored-by: Jakub Nyckowski <jakub.nyckowski@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the error messages in the lib/teleterm/teleterm_test.go and lib/auth/tls_test.go test files from "tls: bad certificate" to more specific ones ("tls: certificate required", "unknown certificate authority") to accurately reflect the Go 1.21 update in the TLS server behavior.