[v13] Fix test after Go 1.21 upgrade#38009
Merged
codingllama merged 1 commit intobranch/v13from Feb 9, 2024
Merged
Conversation
* Fix test after Go 1.21 upgrade
Updated the error messages in the lib/teleterm/teleterm_test.go and lib/auth/tls_test.go test files from "tls: bad certificate" to more specific ones ("tls: certificate required", "unknown certificate authority") to accurately reflect the Go 1.21 update in the TLS server behavior.
* Apply suggestions from code review
Co-authored-by: Alan Parra <alan.parra@goteleport.com>
---------
Co-authored-by: Alan Parra <alan.parra@goteleport.com>
codingllama
added
the
no-changelog
Merged
tigrato
approved these changes
Feb 9, 2024
strideynet
approved these changes
Feb 9, 2024
rosstimothy
approved these changes
Feb 9, 2024
zmb3
approved these changes
Feb 9, 2024
wadells
approved these changes
Feb 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fully backport #30201 to branch/v13, in the process fixing the flaky rotation and rollback tests.
I wrongly left this line out of #37561, believing it was not necessary (as it was removed from master).