Skip to content

[v13] fix: Tidy integrations/kube-agent-updater/go.mod#37935

Merged
wadells merged 1 commit intobranch/v13from
codingllama/fix-kubeagentupdater-v13
Feb 8, 2024
Merged

[v13] fix: Tidy integrations/kube-agent-updater/go.mod#37935
wadells merged 1 commit intobranch/v13from
codingllama/fix-kubeagentupdater-v13

Conversation

@codingllama
Copy link
Copy Markdown
Contributor

The go.mod file is untidy and causing problems for the lint checks.

Since #34462 (or maybe even earlier than that) the min Go version for the module, as required by its dependencies (namely github.com/sigstore/cosign/v2 v2.2.1), is Go 1.21.

@codingllama codingllama added the no-changelog Indicates that a PR does not require a changelog entry label Feb 8, 2024
@codingllama codingllama requested a review from wadells February 8, 2024 17:33
@github-actions github-actions Bot requested review from hugoShaka and jentfoo February 8, 2024 17:34
@wadells
Copy link
Copy Markdown
Contributor

wadells commented Feb 8, 2024

Do you understand why lint didn't fail on #34462 and subsequent PRs? What were we missing?

@codingllama
Copy link
Copy Markdown
Contributor Author

Fixes the issues spotted by #37679, #37875 and possibly others.

I'm not sure why this wasn't a problem until now, but I suspect it's related to our recent Go toolchain update (ie #37561).

I've checked the other go.mod files and they all seem to be tidy.

@codingllama
Copy link
Copy Markdown
Contributor Author

I've checked the go.mods of all other active branches, for good measure. Everything seems to be OK.

Fish snippet:

find . -name go.mod | while read f
    echo $f
    pushd (dirname $f)
    go mod tidy
    popd
end

@codingllama codingllama enabled auto-merge February 8, 2024 17:50
@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from jentfoo February 8, 2024 17:53
@codingllama codingllama added this pull request to the merge queue Feb 8, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 8, 2024
@codingllama codingllama added this pull request to the merge queue Feb 8, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 8, 2024
@codingllama codingllama added this pull request to the merge queue Feb 8, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 8, 2024
@codingllama codingllama added this pull request to the merge queue Feb 8, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 8, 2024
@wadells wadells added this pull request to the merge queue Feb 8, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 8, 2024
@wadells wadells added this pull request to the merge queue Feb 8, 2024
@codingllama
Copy link
Copy Markdown
Contributor Author

It looks like this ain't passing the Rotation tests, which is another can of worms. Sadly I won't have time to purse this right now.

@wadells
Copy link
Copy Markdown
Contributor

wadells commented Feb 8, 2024

AFAICT, these test failures are unrelated to the changes herein. As someone relatively unfamiliar, I don't see what kube-agent-updater would have to do with the rotation tests. Do you have reason to believe otherwise?

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 8, 2024
@codingllama
Copy link
Copy Markdown
Contributor Author

I don't think they have to do with this PR, but I suspect they might be more prevalent since the go update too.

@wadells
Copy link
Copy Markdown
Contributor

wadells commented Feb 8, 2024

I'm going to turn of the requirement for Unit Tests (Go) for a couple minutes to get this in.

https://github.com/gravitational/github-terraform/pull/799

At least this way linting won't block that fix when we get there.

@codingllama
Copy link
Copy Markdown
Contributor Author

Thanks! I'll see if I can figure something out before my day ends.

@wadells wadells added this pull request to the merge queue Feb 8, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 8, 2024
@wadells wadells merged commit 6ab0191 into branch/v13 Feb 8, 2024
@wadells wadells deleted the codingllama/fix-kubeagentupdater-v13 branch February 8, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport no-changelog Indicates that a PR does not require a changelog entry size/sm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants