[v13] fix: Tidy integrations/kube-agent-updater/go.mod#37935
[v13] fix: Tidy integrations/kube-agent-updater/go.mod#37935wadells merged 1 commit intobranch/v13from
Conversation
|
Do you understand why lint didn't fail on #34462 and subsequent PRs? What were we missing? |
|
I've checked the go.mods of all other active branches, for good measure. Everything seems to be OK. Fish snippet: find . -name go.mod | while read f
echo $f
pushd (dirname $f)
go mod tidy
popd
end |
|
It looks like this ain't passing the Rotation tests, which is another can of worms. Sadly I won't have time to purse this right now. |
|
AFAICT, these test failures are unrelated to the changes herein. As someone relatively unfamiliar, I don't see what kube-agent-updater would have to do with the rotation tests. Do you have reason to believe otherwise? |
|
I don't think they have to do with this PR, but I suspect they might be more prevalent since the go update too. |
|
I'm going to turn of the requirement for https://github.com/gravitational/github-terraform/pull/799 At least this way linting won't block that fix when we get there. |
|
Thanks! I'll see if I can figure something out before my day ends. |
The go.mod file is untidy and causing problems for the lint checks.
Since #34462 (or maybe even earlier than that) the min Go version for the module, as required by its dependencies (namely github.com/sigstore/cosign/v2 v2.2.1), is Go 1.21.