Install @protobuf-ts/plugin in the build containers#37010
Closed
Install @protobuf-ts/plugin in the build containers#37010
@protobuf-ts/plugin in the build containers#37010Conversation
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
ryanclark
added
the
no-changelog
ravicious
approved these changes
Jan 22, 2024
ryanclark
force-pushed
the
ryan/add-ts-protobufs-to-dockerfiles
branch
from
0d47326 to
fed5a1c
Compare
jakule
reviewed
Jan 22, 2024
| ARG NODE_PROTOC_TS_VERSION # eg, "5.0.1" | ||
| RUN npm install --global "grpc-tools@$NODE_GRPC_TOOLS_VERSION" "grpc_tools_node_protoc_ts@$NODE_PROTOC_TS_VERSION" | ||
| ARG PROTOBUF_TS_PLUGIN_VERSION # eg, "2.9.3" | ||
| RUN npm install --global "grpc-tools@$NODE_GRPC_TOOLS_VERSION" "grpc_tools_node_protoc_ts@$NODE_PROTOC_TS_VERSION" "@protobuf-ts/plugin@$PROTOBUF_TS_PLUGIN_VERSION" |
Contributor
There was a problem hiding this comment.
Is this needed in the Ci container? We're not using it to generate proto files.
Member
Author
There was a problem hiding this comment.
Yes, the usage is in a follow up PR
gzdunek
approved these changes
Jan 24, 2024
public-teleport-github-review-bot
Bot
removed request for
bl-nero and
nklaassen
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This was referenced Feb 27, 2024
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This installs
@protobuf-ts/pluginalongside the existing JS protobuf generation libraries so we can use it in #37009It also changes buf to use
npm execto useprotoc-gen-tsinstalled bygrpc_tools_node_protoc_ts, as it tries to pick up the@protobuf-ts/plugin/bin/protoc-gen-tsotherwise