Conversation
mdwn
added
backport/branch/v13
no-changelog
codingllama
left a comment
codingllama
left a comment
There was a problem hiding this comment.
Thanks for doing this!
public-teleport-github-review-bot
Bot
removed request for
fheinecke and
greedy52
grpc_tools_node_protoc_ts has been updated to 5.3.2. This version supports proto3 optionals, which 5.0.1 does not. The changes in the generated ts files are whitespace changes save for the google protobuf bits, which look to have changed fairly extensively.
mdwn
force-pushed
the
mike.wilson/update-grpc-tools-node-protoc-ts
branch
from
c0360a1 to
c28e279
Compare
There was a problem hiding this comment.
As far as I know, long term we want to get rid grpc_tools_node_protoc_ts because we have switched to protobuf-ts. See #37010 and:
teleport/build.assets/genproto.sh
Lines 75 to 94 in eb58a01
I saw your message on Slack about issues with Buildbox. If the version of grpc_tools_node_protoc_ts gives you troubles, you should be able to rip out buf-js.gen.yaml and its use from genproto.sh and leave the buildbox cleanup to us.
There was a problem hiding this comment.
v15 uses protobuf-ts, v13 and v14 continue to use grpc_tools_node_protoc_ts.
There was a problem hiding this comment.
Is there any plan to use protobuf-ts for v13/v14 as well?
There was a problem hiding this comment.
No, the switch was done during the test plan in #36921 and we retested v15 soon after that. We wouldn't have time to do the same for v13 and v14 as well.
|
Closing this as it doesn't really apply to master/v15. |
4 participants
grpc_tools_node_protoc_ts has been updated to 5.3.2. This version supports proto3 optionals, which 5.0.1 does not. The changes in the generated ts files are whitespace changes save for the google protobuf bits, which look to have changed fairly extensively.
Note: I'm working on verifying this now, but any pointers on what exactly to verify would be appreciated.