Specify the path for protoc-gen-ts so it doesn't use @protobuf-ts/plugin#37011
Closed
ryanclark wants to merge 2 commits intoryan/add-ts-protobufs-to-dockerfilesfrom
Closed
Specify the path for protoc-gen-ts so it doesn't use @protobuf-ts/plugin#37011ryanclark wants to merge 2 commits intoryan/add-ts-protobufs-to-dockerfilesfrom
ryanclark wants to merge 2 commits intoryan/add-ts-protobufs-to-dockerfilesfrom
Conversation
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
ryanclark
added
the
no-changelog
Member
Author
|
Closing as we are going to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once #37010 merges, the JS protobuf generation will fail (
@protobuf-ts/pluginandgrpc_tools_node_protoc_tsboth have binaries namedprotoc-gen-ts, and it picks up the wrong one)This specifies the path to the correct
protoc-gen-ts. I can't add this to #37010 because the build uses a cached Docker image which doesn't have the name collision issue, so the path doesn't exist.