Generate TypeScript protobuf files#37009
Merged
Conversation
ryanclark
added
the
no-changelog
ryanclark
requested review from
camscale,
fheinecke,
klizhentas,
r0mant,
russjones,
tcsc and
zmb3
as code owners
11 tasks
|
@ryanclark - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
ryanclark
changed the base branch from
master
to
ryan/add-ts-protobufs-to-dockerfiles
ryanclark
force-pushed
the
ryan/generate-ts-protos
branch
from
31bb244 to
8a7765d
Compare
ravicious
approved these changes
Jan 22, 2024
ryanclark
force-pushed
the
ryan/add-ts-protobufs-to-dockerfiles
branch
from
0d47326 to
fed5a1c
Compare
gzdunek
approved these changes
Jan 22, 2024
camscale
approved these changes
Jan 25, 2024
Member
Author
|
As this PR uses Edit: that PR installing |
zmb3
approved these changes
Jan 25, 2024
public-teleport-github-review-bot
Bot
removed request for
fheinecke,
klizhentas,
r0mant,
russjones and
tcsc
ryanclark
changed the base branch from
ryan/add-ts-protobufs-to-dockerfiles
to
master
ryanclark
force-pushed
the
ryan/generate-ts-protos
branch
from
6bbc0d5 to
dcf0b78
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
|
@ryanclark See the table below for backport results.
|
Member
|
Let's backport this ASAP to avoid issues with master having different protos than v15. |
This was referenced Jan 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds TypeScript protobuf generation to support Connect's move to Vite (#36921)
The existing generation for JS files with TypeScript definitions remains untouched and will be removed after Connect has moved to Vite and they're no longer referenced.