Scoped WebAuthn: Refactor SessionData#36666
Merged
Conversation
Joerger
added
the
no-changelog
Joerger
changed the title
SessionData
codingllama
reviewed
Jan 15, 2024
Joerger
force-pushed
the
joerger/scoped-webauthn-session-data
branch
from
bfefc29 to
837f078
Compare
rosstimothy
approved these changes
Jan 16, 2024
Joerger
force-pushed
the
joerger/scoped-webauthn-session-data
branch
from
837f078 to
adeba02
Compare
GavinFrazar
approved these changes
Jan 16, 2024
Joerger
force-pushed
the
joerger/scoped-webauthn-session-data
branch
from
adeba02 to
745a86d
Compare
codingllama
approved these changes
Jan 17, 2024
Contributor
codingllama
left a comment
codingllama
left a comment
There was a problem hiding this comment.
Please address the comments, otherwise LGTM.
Contributor
|
It also looks like you have a few test failures. |
Joerger
force-pushed
the
joerger/scoped-webauthn-session-data
branch
from
745a86d to
8e3a094
Compare
Contributor
Author
Joerger
force-pushed
the
joerger/scoped-webauthn-session-data
branch
2 times, most recently
from
945d258 to
7587f2f
Compare
Contributor
Author
|
@codingllama I am still getting flaky test issues with |
Contributor
|
It looks like that when you run multiple tests they interact in a bad way. Let me see what I can do. |
Contributor
Author
…sionData_maxLimit
Contributor
|
Flaky fix at #36945. |
Joerger
force-pushed
the
joerger/scoped-webauthn-session-data
branch
from
7587f2f to
a092a54
Compare
Joerger
changed the base branch from
master
to
codingllama/globallimiter-flaky-again
Base automatically changed from
codingllama/globallimiter-flaky-again
to
master
January 19, 2024 21:09
Joerger
added a commit
that referenced
this pull request
Jan 19, 2024
* fix: Use random scopes on TestIdentityService_UpsertGlobalWebauthnSessionData_maxLimit * Replace webauthn SessionData proto definition with an internal definition. * Remove unused SessionData proto message. * Address comments; Fix test. --------- Co-authored-by: Alan Parra <alan.parra@goteleport.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 20, 2024
* fix: Use random scopes on TestIdentityService_UpsertGlobalWebauthnSessionData_maxLimit * Replace webauthn SessionData proto definition with an internal definition. * Remove unused SessionData proto message. * Address comments; Fix test. --------- Co-authored-by: Alan Parra <alan.parra@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves custom webauthn
SessionDatastruct out ofwebauthn.prototo an internal implementation. This struct was previously only used to standardize json marshalling/unmarshalling for backend storage. Now it also includes Teleport extensions.This was requested as part of the work for Scoped Webauthn Challenges.