[v15] Scoped WebAuthn: Refactor SessionData#36958
Merged
Joerger merged 2 commits intobranch/v15from Jan 20, 2024
Merged
Conversation
* fix: Use random scopes on TestIdentityService_UpsertGlobalWebauthnSessionData_maxLimit * Replace webauthn SessionData proto definition with an internal definition. * Remove unused SessionData proto message. * Address comments; Fix test. --------- Co-authored-by: Alan Parra <alan.parra@goteleport.com>
github-actions
Bot
requested review from
GavinFrazar,
codingllama,
ibeckermayer and
rosstimothy
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
Joerger
added
the
no-changelog
GavinFrazar
approved these changes
Jan 19, 2024
rosstimothy
approved these changes
Jan 19, 2024
public-teleport-github-review-bot
Bot
removed request for
codingllama and
ibeckermayer
Joerger
changed the title
SessionData
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #36666 to branch/v15