Conversation
fce5a27 to
f247bb3
Compare
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
abe66f2 to
d4799d1
Compare
…e opportunistically.
d4799d1 to
9a0668c
Compare
mdwn
left a comment
There was a problem hiding this comment.
So, admittedly this review was a bit daunting to me. It looks pretty straightforward as a replacement of more "basic" MFA with scoped MFA. I can't speak to the validity of the scopes, but otherwise LGTM.
| return nil | ||
| } | ||
|
|
||
| if err := a.authorizeAdminAction(ctx, authContext); err != nil { |
There was a problem hiding this comment.
nit: You could replace this if statement and the subsequent return with just
return trace.Wrap(a.authorizeAdminAction(ctx, authContext)
codingllama
left a comment
There was a problem hiding this comment.
A few more comments.
I can say with certainty now that this PR is too big. Please split into smaller, self-focused parts.
A few split ideas:
- Proto definitions
- (Possible) Make SessionData a storage-only type
- Add scopes lib/auth/webauthn (minimal code changes elsewhere)
- Add scopes to other important methods (server-side)
- Add scopes to other important methods (client-side)
- Teleport binary changes (if significant/not part of the above)
- Web UI changes
Implements scoped Webauthn challenges as described in #35185.
Follow up PRs:
changelog: Add scope to WebAuthn challenges