Scoped WebAuthn: MFA extension flow#36667
Merged
Conversation
Joerger
added
the
no-changelog
Joerger
force-pushed
the
joerger/scoped-webauthn-extension-flow
branch
from
32a648f to
4f4aae9
Compare
codingllama
reviewed
Jan 15, 2024
Contributor
codingllama
left a comment
codingllama
left a comment
There was a problem hiding this comment.
A few design-related comments.
Let's avoid ext param/variable names, as there are already "extensions" in WebAuthn (and it means something else).
Joerger
force-pushed
the
joerger/scoped-webauthn-session-data
branch
from
bfefc29 to
837f078
Compare
Joerger
force-pushed
the
joerger/scoped-webauthn-extension-flow
branch
from
4f4aae9 to
66295be
Compare
Joerger
force-pushed
the
joerger/scoped-webauthn-session-data
branch
from
837f078 to
adeba02
Compare
Joerger
force-pushed
the
joerger/scoped-webauthn-extension-flow
branch
from
66295be to
cbe1586
Compare
Joerger
changed the title
Joerger
force-pushed
the
joerger/scoped-webauthn-session-data
branch
from
adeba02 to
745a86d
Compare
Joerger
force-pushed
the
joerger/scoped-webauthn-extension-flow
branch
from
cfffb4e to
1f38429
Compare
Joerger
force-pushed
the
joerger/scoped-webauthn-extension-flow
branch
from
b4dcbd5 to
fde16ef
Compare
codingllama
reviewed
Jan 17, 2024
Joerger
force-pushed
the
joerger/scoped-webauthn-session-data
branch
from
745a86d to
8e3a094
Compare
Joerger
force-pushed
the
joerger/scoped-webauthn-extension-flow
branch
from
fde16ef to
0d2d119
Compare
Joerger
force-pushed
the
joerger/scoped-webauthn-extension-flow
branch
2 times, most recently
from
4040b97 to
f1ee37c
Compare
rosstimothy
approved these changes
Jan 18, 2024
codingllama
approved these changes
Jan 18, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from justinas
Joerger
force-pushed
the
joerger/scoped-webauthn-extension-flow
branch
from
f1ee37c to
c6a557b
Compare
Joerger
force-pushed
the
joerger/scoped-webauthn-session-data
branch
from
25caa59 to
3211003
Compare
Joerger
force-pushed
the
joerger/scoped-webauthn-extension-flow
branch
from
c6a557b to
2a8cd1f
Compare
Joerger
force-pushed
the
joerger/scoped-webauthn-session-data
branch
2 times, most recently
from
7587f2f to
a092a54
Compare
Joerger
force-pushed
the
joerger/scoped-webauthn-extension-flow
branch
from
2a8cd1f to
37e2768
Compare
Base automatically changed from
joerger/scoped-webauthn-session-data
to
master
January 19, 2024 21:40
Joerger
force-pushed
the
joerger/scoped-webauthn-extension-flow
branch
from
37e2768 to
1608482
Compare
Joerger
added a commit
that referenced
this pull request
Jan 21, 2024
* Use SessionData with extensions in Webauthn flow. * Pass MFAChallengeExtensions through webauthn flow. * Opportunistically enforce Webauthn challenge scope. * Don't delete webauthn session data when reuse is allowed. * Return more login data from webauthn flow. * Enforce reuse when provided by the caller. * Address comments. * Fix test. * Add unit test for scope and reuse. * use pointer for challenge extension parameters. * Address comments.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 22, 2024
* Use SessionData with extensions in Webauthn flow. * Pass MFAChallengeExtensions through webauthn flow. * Opportunistically enforce Webauthn challenge scope. * Don't delete webauthn session data when reuse is allowed. * Return more login data from webauthn flow. * Enforce reuse when provided by the caller. * Address comments. * Fix test. * Add unit test for scope and reuse. * use pointer for challenge extension parameters. * Address comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate and enforce MFA challenge extensions in the WebAuthn login flow.
Part of the implementation for RFD 155
Based off #36666