Remove the webauthn.User proto#39950
Merged
codingllama merged 3 commits intomasterfrom Mar 28, 2024
Merged
Conversation
codingllama
added
the
no-changelog
codingllama
commented
Mar 28, 2024
| // Used mainly to correlated a WebAuthn user handle with a Teleport user. | ||
| type User struct { | ||
| // Teleport user ID. | ||
| TeleportUser string `protobuf:"bytes,1,opt,name=teleport_user,json=teleportUser,proto3" json:"teleport_user,omitempty"` |
Contributor
Author
There was a problem hiding this comment.
It's pretty confusing to figure out which json tag is used, but it's actually the snake_case one. Confirmed by marshaling a webauthn.User (before removing) and by looking at the sqlite key (before applying the change).
$ select * from kv where key like '/webauthn/users/%';
> /webauthn/users/N2I4Y2QzZDAtYTU2OS00NDMzLWE1MzktYjkxZTgwZWQ3ZTVm|1711633239496051000||{"teleport_user":"llama"}|c0224976-44d1-4c06-9f1a-eed41a5e9bbb
> /webauthn/users/ZjAxM2QxNDQtODQ1ZS00OGEzLTkyMGItMjE4NTU2MzhmMjVm|1711634315315319000||{"teleport_user":"alpaca"}|e9a1527b-e33f-4011-a14f-1e97ce6f8d6c
zmb3
approved these changes
Mar 28, 2024
greedy52
approved these changes
Mar 28, 2024
public-teleport-github-review-bot
Bot
removed the request for review
from espadolini
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the User type storage-only, similarly to the removal of SessionData from webauthn.proto (#36666).
This is just a cleanup, no behavioral changes.