[v12] Replace Webpack with Vite#26149
Conversation
ce88a28 to
459f440
Compare
There was a problem hiding this comment.
Why is this needed on v12 and not on master?
There was a problem hiding this comment.
On master/v13, the dependencies for swc are set in yarn.lock to the versions that work. If I don't pin this, we get an incompatible @swc/core package and the build errors.
There was a problem hiding this comment.
I see that master uses @vitejs/plugin-react-swc ^3.2.0 vs ^3.3.1 on this branch. I managed to massage yarn.lock into resolving @swc/core to 1.3.36 (a1bfb9f) by doing this:
- Remove @vitejs/plugin-react-swc from package json.
- Run
yarn. - Add it back to package.json with
"@vitejs/plugin-react-swc": "~3.2.0"(this won't upgrade it past 3.2.x). - Run
yarn. - Remove @swc/core resolution.
What do you think about about restricting plugin-react-swc to ~3.2.0 instead of adding that @swc/core resolution? I care about this only because adding a resolution is a pretty heavy-handed hammer that I think we should use only as a last resort.
There was a problem hiding this comment.
It looks like the changes here cause some type errors to pop up in web/packages/teleterm. I wonder why it's the case on v12 and not on v13/master. 🤔
|
@ryanclark I'm going to close this one - it hasn't been touched in 4 months and eventually v12 will die out. |
Yeah fair enough. I didn't pick it back up as it seemed v12 wasn't going to be supported for much longer, I just forgot to close it |
Backport Vite to v12
Original PR - #21168
Includes changes from