Skip to content

[v12] Replace Webpack with Vite#26149

Closed
ryanclark wants to merge 5 commits intobranch/v12from
ryan/v12-vite
Closed

[v12] Replace Webpack with Vite#26149
ryanclark wants to merge 5 commits intobranch/v12from
ryan/v12-vite

Conversation

@ryanclark
Copy link
Copy Markdown
Member

@ryanclark ryanclark commented May 12, 2023

@ryanclark ryanclark requested a review from kimlisa May 12, 2023 16:31
@ryanclark ryanclark force-pushed the ryan/v12-vite branch 2 times, most recently from ce88a28 to 459f440 Compare May 12, 2023 18:08
Comment thread package.json Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed on v12 and not on master?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On master/v13, the dependencies for swc are set in yarn.lock to the versions that work. If I don't pin this, we get an incompatible @swc/core package and the build errors.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that master uses @vitejs/plugin-react-swc ^3.2.0 vs ^3.3.1 on this branch. I managed to massage yarn.lock into resolving @swc/core to 1.3.36 (a1bfb9f) by doing this:

  1. Remove @vitejs/plugin-react-swc from package json.
  2. Run yarn.
  3. Add it back to package.json with "@vitejs/plugin-react-swc": "~3.2.0" (this won't upgrade it past 3.2.x).
  4. Run yarn.
  5. Remove @swc/core resolution.

What do you think about about restricting plugin-react-swc to ~3.2.0 instead of adding that @swc/core resolution? I care about this only because adding a resolution is a pretty heavy-handed hammer that I think we should use only as a last resort.

Comment thread tsconfig.node.json Outdated
Comment thread tsconfig.json Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the changes here cause some type errors to pop up in web/packages/teleterm. I wonder why it's the case on v12 and not on v13/master. 🤔

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take a look

@zmb3
Copy link
Copy Markdown
Collaborator

zmb3 commented Sep 20, 2023

@ryanclark I'm going to close this one - it hasn't been touched in 4 months and eventually v12 will die out.

@zmb3 zmb3 closed this Sep 20, 2023
@ryanclark
Copy link
Copy Markdown
Member Author

@ryanclark I'm going to close this one - it hasn't been touched in 4 months and eventually v12 will die out.

Yeah fair enough. I didn't pick it back up as it seemed v12 wasn't going to be supported for much longer, I just forgot to close it

@ryanclark ryanclark deleted the ryan/v12-vite branch September 21, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants