Fix styled-components CSS prop in Storybook#23427
Merged
Conversation
ryanclark
changed the title
ryanclark
force-pushed
the
ryan/fix-storybook-css-prop
branch
from
6fb9d4e to
36c20a1
Compare
ravicious
approved these changes
Mar 22, 2023
zmb3
approved these changes
Mar 22, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from hatched
ravicious
pushed a commit
that referenced
this pull request
Mar 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes for Vite made the JSX get parsed at the TypeScript transform level instead of preserving it for babel to transform.
This fixes that by setting
jsx: preservefor Storybook's Webpack config, so babel continues to parse styled-component'scsspropBefore:
After:
