Move the favicon so Teleport serves the static file#26084
Merged
Conversation
ravicious
approved these changes
May 12, 2023
|
@ryanclark See the table below for backport results.
|
This was referenced May 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vite copies files from
public/to the output directory, which isn't ideal as Teleport doesn't serve static assets unless they're in theapp/directory inside the output directory.There's no option to move where it copies to, so to get Teleport to serve the favicon, I moved it into
public/appso it outputs it into theappfolder.