Fix vite development for desktop websocket endpoint#23815
Merged
ibeckermayer merged 2 commits intomasterfrom Mar 30, 2023
Merged
Fix vite development for desktop websocket endpoint#23815ibeckermayer merged 2 commits intomasterfrom
ibeckermayer merged 2 commits intomasterfrom
Conversation
added 2 commits
March 29, 2023 17:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
changeOriginis set totrue, the origin of the request is changed tolocalhost:3000, which upsets Gorilla websocket's default origin check which is expecting the originlocalhost:3080(the origin the server is running from).Also includes a minor correction in the README.