feat(source/dataplex)!: restructure prebuilt toolsets

[averikitsch]

Description

Should include a concise description of the changes (bug or feature), it's
impact, along with a summary of the solution

PR Checklist

Thank you for opening a Pull Request! Before submitting your PR, there are a
few things you can do to make sure it goes smoothly:

• Make sure you reviewed
  CONTRIBUTING.md
• Make sure to open an issue as a
  bug/issue
  before writing your code! That way we can discuss the change, evaluate
  designs, and agree on the general idea
• Ensure the tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)
• Make sure to add ! if this involve a breaking change

🛠️ Fixes #<issue_number_goes_here>

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors and enhances the prebuilt toolset definitions and their corresponding test infrastructure. The primary goal is to improve clarity in toolset naming, introduce validation for toolset sizes, and refine existing test cases for robustness and efficiency. These changes contribute to a more maintainable and reliable system for managing and testing prebuilt tools.

Highlights

• Toolset Renaming: The 'dataplex_tools' toolset has been renamed to 'discovery' across its configuration file and associated test cases, aligning with a more generic naming convention.
• Toolset Size Validation: A new test has been introduced to log warnings if any prebuilt toolset exceeds a recommended maximum of 10 tools, promoting better toolset design.
• Test Case Re-enablement: A previously disabled test case for listing schemas with an owner name has been re-enabled, indicating a resolution to a prior issue.
• Test Cleanup Simplification: The cleanupOldSchemas function and its associated logic have been removed, streamlining test setup and teardown for stored procedure tests.
• Stored Procedure Definition Check: The validation for stored procedure definitions has been made more precise, now specifically checking for the literal string 'CREATE PROCEDURE' instead of a case-insensitive check for 'PROCEDURE'.
• New Test Helper Function: A new utility function, RunStatementToolsTest, was added to simplify the execution and validation of statement-based tool invocations in tests.

Changelog

• cmd/internal/tools_file_test.go
  • Updated the 'dataplex prebuilt tools' test case to reflect the renaming of 'dataplex_tools' to 'discovery'.
  • Added a new sub-test to check and log warnings for toolsets exceeding a recommended size of 10 tools.
• internal/prebuiltconfigs/tools/dataplex.yaml
  • Renamed the 'dataplex_tools' toolset to 'discovery'.
• tests/tool.go
  • Removed the unused strconv import.
  • Re-enabled a previously commented-out test case for list_schemas with an owner name.
  • Removed the cleanupOldSchemas function, simplifying test environment management.
  • Modified the schema naming convention for test procedures, removing the timestamp component.
  • Updated the stored procedure definition verification to specifically check for 'CREATE PROCEDURE'.
  • Added a new helper function RunStatementToolsTest for executing and validating statement tool invocations.

Activity

• The pull request was created by averikitsch, initiating the review process.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request restructures the Dataplex prebuilt toolset by renaming it to discovery, which improves clarity. The changes are consistent across the test and configuration files. The PR also includes several unrelated but useful test improvements for Postgres, such as re-enabling a disabled test. I have two suggestions for further improving the test code: one to remove redundant logging and another regarding the removal of a cleanup mechanism for test schemas, which could impact the long-term stability of the test environment.

I am having trouble creating individual review comments. Click here to see my feedback.

cmd/internal/tools_file_test.go (1967-1968)

The use of both t.Logf and fmt.Printf to log the same warning is redundant. t.Logf is the standard way to log information within a Go test, and its output is visible when running tests with the -v flag. The additional fmt.Printf call adds unnecessary noise to the standard output. Please remove it to keep the test logs clean.

                                                t.Logf("WARNING: Toolset %q in config %q has %d tools, which is larger than the recommended maximum of 10.", tsName, tc.name, len(ts.ToolNames))

tests/tool.go (4421-4454)

The cleanupOldSchemas function, which served as a safety net to clean up stale test schemas from aborted test runs, has been removed. While individual tests now seem to handle their own cleanup via defer, removing this fallback mechanism could lead to an accumulation of orphaned schemas in the test environment over time, potentially causing test flakiness or performance degradation. Please consider restoring a periodic cleanup mechanism, perhaps as a separate CI job or by adapting this function to work with the new schema naming convention (e.g., by using creation timestamps from the database's metadata if available, instead of parsing them from the schema name).