feat(source/firestore)!: restructure prebuilt toolsets

[averikitsch]

Description

Should include a concise description of the changes (bug or feature), it's
impact, along with a summary of the solution

PR Checklist

Thank you for opening a Pull Request! Before submitting your PR, there are a
few things you can do to make sure it goes smoothly:

• Make sure you reviewed
  CONTRIBUTING.md
• Make sure to open an issue as a
  bug/issue
  before writing your code! That way we can discuss the change, evaluate
  designs, and agree on the general idea
• Ensure the tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)
• Make sure to add ! if this involve a breaking change

🛠️ Fixes #<issue_number_goes_here>

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the organization of prebuilt toolsets for BigQuery and Firestore, moving from single, large toolsets to smaller, more focused ones. This change aims to improve the clarity and usability of these toolsets, potentially enhancing their performance and maintainability. Additionally, it introduces a new validation step to ensure toolsets adhere to a recommended size limit and cleans up some existing test infrastructure.

Highlights

• Prebuilt Toolset Restructuring: Restructured prebuilt toolsets for BigQuery and Firestore, splitting monolithic toolsets into more granular, domain-specific ones (e.g., 'data', 'analytics', 'security').
• Toolset Size Validation: Introduced a new test to warn if toolsets exceed a recommended size of 10 tools, promoting better toolset design and manageability.
• Postgres Test Refinements: Refactored Postgres test utilities by removing an old schema cleanup function, re-enabling a previously disabled test case, and simplifying test schema naming.

Changelog

• cmd/internal/tools_file_test.go
  • Updated BigQuery prebuilt toolset test configuration to reflect the new 'data' and 'analytics' toolsets.
  • Updated Firestore prebuilt toolset test configuration to reflect the new 'data' and 'security' toolsets.
  • Added a new sub-test to check if any toolset exceeds a recommended size of 10 tools, logging a warning if it does.
• internal/prebuiltconfigs/tools/firestore.yaml
  • Split the 'firestore_database_tools' toolset into two new toolsets: 'data' (containing document and collection management tools) and 'security' (containing rules management tools).
• tests/tool.go
  • Removed the unused 'strconv' import.
  • Re-enabled a previously commented-out test case for 'list_schemas' with an owner name.
  • Removed the 'cleanupOldSchemas' function, which was responsible for cleaning up old test schemas.
  • Removed the call to 'cleanupOldSchemas' from 'RunPostgresListStoredProcedureTest'.
  • Simplified the naming convention for test schemas in 'RunPostgresListStoredProcedureTest'.
  • Modified the 'CREATE PROCEDURE' check to be more specific.
  • Added a new helper function 'RunStatementToolsTest' for executing tool statements.

Activity

• No specific activity (comments, reviews) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request restructures the prebuilt toolsets for BigQuery and Firestore, splitting them into more granular categories like data, analytics, and security. This improves organization. The PR also includes several test improvements, such as re-enabling a previously skipped test, simplifying test setup, and adding a new test helper. I've identified a couple of areas for improvement regarding code style and consistency.