fix(oracle): update oracle-execute-sql tool interface to match source signature by anubhav756 · Pull Request #2627 · googleapis/mcp-toolbox

anubhav756 · 2026-03-04T19:55:14Z

Description

This PR fixes a critical signature mismatch that caused all oracle-execute-sql tool invocations to fail with an incompatible source type error (500 Internal Server Error).

In a previous PR (#2323), the RunSQL method in the Oracle Source was updated to include a readOnly bool parameter to support DML operations for the oracle-sql tool:

However, the oracle-execute-sql tool's required interface (compatibleSource) was inadvertently left unchanged, still expecting the old 3-argument signature. Because Go interfaces are satisfied implicitly, the updated Oracle source no longer implemented the oracle-execute-sql tool's interface, causing tools.GetCompatibleSource to reject it at runtime during invocation.

🛠️ Fixes #2614

gemini-code-assist · 2026-03-04T19:55:29Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug where the oracle-execute-sql tool failed to invoke correctly due to an interface signature mismatch. The fix involves updating the tool's internal interface definition and its call site to align with recent changes in the Oracle Source's RunSQL method, thereby restoring proper functionality and preventing internal server errors.

Highlights

Critical Bug Fix: Resolved a critical signature mismatch in the oracle-execute-sql tool, which previously caused 500 Internal Server Error during tool invocations.
Interface Update: Updated the compatibleSource interface definition to include the readOnly boolean parameter in the RunSQL method, aligning it with the Oracle Source's RunSQL method signature.
Tool Invocation Correction: Modified the Invoke method to pass the new readOnly parameter (set to false) when calling source.RunSQL, ensuring correct tool execution.

Changelog

internal/tools/oracle/oracleexecutesql/oracleexecutesql.go
- Updated the compatibleSource interface to include a bool parameter in the RunSQL method signature.
- Modified the Invoke method to pass false for the new readOnly parameter when calling source.RunSQL.

Activity

No human activity (comments, reviews, progress updates) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request successfully addresses a signature mismatch in the compatibleSource interface for the oracle-execute-sql tool, resolving a runtime error. However, hardcoding the readOnly parameter to false in the RunSQL call introduces a critical security vulnerability, allowing destructive SQL operations via prompt injection if exposed to an LLM. Additionally, this change inadvertently breaks the functionality for SELECT queries, as they will no longer return data. It is strongly recommended to default to read-only mode (readOnly: true) to mitigate these risks and ensure correct SELECT statement behavior.

internal/tools/oracle/oracleexecutesql/oracleexecutesql.go

duwenxin99

Can we add regression tests in a subsequent PR? Thanks!

anubhav756 · 2026-03-04T20:50:40Z

Can we add regression tests in a subsequent PR? Thanks!

Added regression tests in this PR for convenience.

… signature

…rsing

…h source signature (googleapis#2627) ## Description This PR fixes a critical signature mismatch that caused all `oracle-execute-sql` tool invocations to fail with an incompatible source type error (`500` Internal Server Error). In a previous PR (googleapis#2323), the `RunSQL` method in the Oracle Source was updated to include a `readOnly` bool parameter to support DML operations for the `oracle-sql` tool: However, the `oracle-execute-sql` tool's required interface (`compatibleSource`) was inadvertently left unchanged, still expecting the old 3-argument signature. Because Go interfaces are satisfied implicitly, the updated Oracle source no longer implemented the `oracle-execute-sql` tool's interface, causing `tools.GetCompatibleSource` to reject it at runtime during invocation. 🛠️ Fixes googleapis#2614 81699a3

… signature (#2627) ## Description This PR fixes a critical signature mismatch that caused all `oracle-execute-sql` tool invocations to fail with an incompatible source type error (`500` Internal Server Error). In a previous PR (#2323), the `RunSQL` method in the Oracle Source was updated to include a `readOnly` bool parameter to support DML operations for the `oracle-sql` tool: However, the `oracle-execute-sql` tool's required interface (`compatibleSource`) was inadvertently left unchanged, still expecting the old 3-argument signature. Because Go interfaces are satisfied implicitly, the updated Oracle source no longer implemented the `oracle-execute-sql` tool's interface, causing `tools.GetCompatibleSource` to reject it at runtime during invocation. 🛠️ Fixes #2614

… signature (googleapis#2627) ## Description This PR fixes a critical signature mismatch that caused all `oracle-execute-sql` tool invocations to fail with an incompatible source type error (`500` Internal Server Error). In a previous PR (googleapis#2323), the `RunSQL` method in the Oracle Source was updated to include a `readOnly` bool parameter to support DML operations for the `oracle-sql` tool: However, the `oracle-execute-sql` tool's required interface (`compatibleSource`) was inadvertently left unchanged, still expecting the old 3-argument signature. Because Go interfaces are satisfied implicitly, the updated Oracle source no longer implemented the `oracle-execute-sql` tool's interface, causing `tools.GetCompatibleSource` to reject it at runtime during invocation. 🛠️ Fixes googleapis#2614

🤖 I have created a release *beep* *boop* --- ## [0.29.0](v0.28.0...v0.29.0) (2026-03-13) ### ⚠ BREAKING CHANGES * **source/alloydb:** restructure prebuilt toolsets ([#2639](#2639)) * **source/spanner:** restructure prebuilt toolsets ([#2641](#2641)) * **source/dataplex:** restructure prebuilt toolsets ([#2640](#2640)) * **source/oss-db:** restructure prebuilt toolsets ([#2638](#2638)) * **source/cloudsql:** restructure prebuilt toolsets ([#2635](#2635)) * **source/bigquery:** restructure prebuilt toolsets ([#2637](#2637)) * **source/firestore:** restructure prebuilt toolsets ([#2636](#2636)) * telemetry metrics updates as per semantic convention ([#2566](#2566)) ### Features * Add user agent to embeddings generation ([#2572](#2572)) ([287251a](287251a)) * **skill:** Attach user agent metadata for generated skill ([#2697](#2697)) ([9598a6a](9598a6a)) * **skills:** Add additional-notes flag to generate skills command ([#2696](#2696)) ([73bf962](73bf962)) * **skill:** Update skill generation logic ([#2646](#2646)) ([c233eee](c233eee)) * **source/alloydb:** Restructure prebuilt toolsets ([#2639](#2639)) ([5f3f063](5f3f063)) * **source/bigquery:** Restructure prebuilt toolsets ([#2637](#2637)) ([dc984ba](dc984ba)) * **sources/bigquery:** Support custom oauth header name ([#2564](#2564)) ([d3baf77](d3baf77)) * **source/cloudsql:** Restructure prebuilt toolsets ([#2635](#2635)) ([99613dc](99613dc)) * **source/dataplex:** Restructure prebuilt toolsets ([#2640](#2640)) ([acb9a80](acb9a80)) * **source/firestore:** Restructure prebuilt toolsets ([#2636](#2636)) ([22ab7b9](22ab7b9)) * **source/oss-db:** Restructure prebuilt toolsets ([#2638](#2638)) ([5196c6a](5196c6a)) * **source/spanner:** Restructure prebuilt toolsets ([#2641](#2641)) ([ea2b698](ea2b698)) * Telemetry metrics updates as per semantic convention ([#2566](#2566)) ([131d764](131d764)) * **tools/mongodb:** Add tool annotations to MongoDB tools for improved LLM understanding ([#2219](#2219)) ([b7a5f80](b7a5f80)) * **tools/serverless-spark:** Add get_session_template tool ([#2308](#2308)) ([a136e16](a136e16)) * **tools/serverless-spark:** Add list/get sessions tools ([#2576](#2576)) ([a554298](a554298)) ### Bug Fixes * Improve list locks integration test for postgres ([#2279](#2279)) ([d9ebe5d](d9ebe5d)) * **mcp:** Guard nil SSE session lookup and return 400 for missing session ([#2681](#2681)) ([f66189f](f66189f)) * **oracle:** Update oracle-execute-sql tool interface to match source signature ([#2627](#2627)) ([81699a3](81699a3)) * Return AllParams for GetParameter() for tools with templateParameter([#2734](#2734)) ([bfd7ba6](bfd7ba6)) * **server/mcp:** Scope defer span.End inside loop iteration ([#2558](#2558)) ([c88a62d](c88a62d)), closes [#2549](#2549) * **skill:** Fix env variable propagation ([#2645](#2645)) ([5271368](5271368)) * **sources/looker:** Looker and looker-dev prebuilt tools should share one source definition. ([#2620](#2620)) ([df7f2fd](df7f2fd)) * **telemetry:** Histogram buckets from OTel standard to MCP standards ([#2729](#2729)) ([87cd4a0](87cd4a0)) * **ui:** Remove module from script ([#2703](#2703)) ([6943ab6](6943ab6)) * Update toolset attributes naming ([#2554](#2554)) ([3d6ae4e](3d6ae4e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [0.29.0](v0.28.0...v0.29.0) (2026-03-13) ### ⚠ BREAKING CHANGES * **source/alloydb:** restructure prebuilt toolsets ([#2639](#2639)) * **source/spanner:** restructure prebuilt toolsets ([#2641](#2641)) * **source/dataplex:** restructure prebuilt toolsets ([#2640](#2640)) * **source/oss-db:** restructure prebuilt toolsets ([#2638](#2638)) * **source/cloudsql:** restructure prebuilt toolsets ([#2635](#2635)) * **source/bigquery:** restructure prebuilt toolsets ([#2637](#2637)) * **source/firestore:** restructure prebuilt toolsets ([#2636](#2636)) * telemetry metrics updates as per semantic convention ([#2566](#2566)) ### Features * Add user agent to embeddings generation ([#2572](#2572)) ([287251a](287251a)) * **skill:** Attach user agent metadata for generated skill ([#2697](#2697)) ([9598a6a](9598a6a)) * **skills:** Add additional-notes flag to generate skills command ([#2696](#2696)) ([73bf962](73bf962)) * **skill:** Update skill generation logic ([#2646](#2646)) ([c233eee](c233eee)) * **source/alloydb:** Restructure prebuilt toolsets ([#2639](#2639)) ([5f3f063](5f3f063)) * **source/bigquery:** Restructure prebuilt toolsets ([#2637](#2637)) ([dc984ba](dc984ba)) * **sources/bigquery:** Support custom oauth header name ([#2564](#2564)) ([d3baf77](d3baf77)) * **source/cloudsql:** Restructure prebuilt toolsets ([#2635](#2635)) ([99613dc](99613dc)) * **source/dataplex:** Restructure prebuilt toolsets ([#2640](#2640)) ([acb9a80](acb9a80)) * **source/firestore:** Restructure prebuilt toolsets ([#2636](#2636)) ([22ab7b9](22ab7b9)) * **source/oss-db:** Restructure prebuilt toolsets ([#2638](#2638)) ([5196c6a](5196c6a)) * **source/spanner:** Restructure prebuilt toolsets ([#2641](#2641)) ([ea2b698](ea2b698)) * Telemetry metrics updates as per semantic convention ([#2566](#2566)) ([131d764](131d764)) * **tools/mongodb:** Add tool annotations to MongoDB tools for improved LLM understanding ([#2219](#2219)) ([b7a5f80](b7a5f80)) * **tools/serverless-spark:** Add get_session_template tool ([#2308](#2308)) ([a136e16](a136e16)) * **tools/serverless-spark:** Add list/get sessions tools ([#2576](#2576)) ([a554298](a554298)) ### Bug Fixes * Improve list locks integration test for postgres ([#2279](#2279)) ([d9ebe5d](d9ebe5d)) * **mcp:** Guard nil SSE session lookup and return 400 for missing session ([#2681](#2681)) ([f66189f](f66189f)) * **oracle:** Update oracle-execute-sql tool interface to match source signature ([#2627](#2627)) ([81699a3](81699a3)) * Return AllParams for GetParameter() for tools with templateParameter([#2734](#2734)) ([bfd7ba6](bfd7ba6)) * **server/mcp:** Scope defer span.End inside loop iteration ([#2558](#2558)) ([c88a62d](c88a62d)), closes [#2549](#2549) * **skill:** Fix env variable propagation ([#2645](#2645)) ([5271368](5271368)) * **sources/looker:** Looker and looker-dev prebuilt tools should share one source definition. ([#2620](#2620)) ([df7f2fd](df7f2fd)) * **telemetry:** Histogram buckets from OTel standard to MCP standards ([#2729](#2729)) ([87cd4a0](87cd4a0)) * **ui:** Remove module from script ([#2703](#2703)) ([6943ab6](6943ab6)) * Update toolset attributes naming ([#2554](#2554)) ([3d6ae4e](3d6ae4e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 39832a0

🤖 I have created a release *beep* *boop* --- ## [0.29.0](googleapis/mcp-toolbox@v0.28.0...v0.29.0) (2026-03-13) ### ⚠ BREAKING CHANGES * **source/alloydb:** restructure prebuilt toolsets ([googleapis#2639](googleapis#2639)) * **source/spanner:** restructure prebuilt toolsets ([googleapis#2641](googleapis#2641)) * **source/dataplex:** restructure prebuilt toolsets ([googleapis#2640](googleapis#2640)) * **source/oss-db:** restructure prebuilt toolsets ([googleapis#2638](googleapis#2638)) * **source/cloudsql:** restructure prebuilt toolsets ([googleapis#2635](googleapis#2635)) * **source/bigquery:** restructure prebuilt toolsets ([googleapis#2637](googleapis#2637)) * **source/firestore:** restructure prebuilt toolsets ([googleapis#2636](googleapis#2636)) * telemetry metrics updates as per semantic convention ([googleapis#2566](googleapis#2566)) ### Features * Add user agent to embeddings generation ([googleapis#2572](googleapis#2572)) ([287251a](googleapis@287251a)) * **skill:** Attach user agent metadata for generated skill ([googleapis#2697](googleapis#2697)) ([9598a6a](googleapis@9598a6a)) * **skills:** Add additional-notes flag to generate skills command ([googleapis#2696](googleapis#2696)) ([73bf962](googleapis@73bf962)) * **skill:** Update skill generation logic ([googleapis#2646](googleapis#2646)) ([c233eee](googleapis@c233eee)) * **source/alloydb:** Restructure prebuilt toolsets ([googleapis#2639](googleapis#2639)) ([5f3f063](googleapis@5f3f063)) * **source/bigquery:** Restructure prebuilt toolsets ([googleapis#2637](googleapis#2637)) ([dc984ba](googleapis@dc984ba)) * **sources/bigquery:** Support custom oauth header name ([googleapis#2564](googleapis#2564)) ([d3baf77](googleapis@d3baf77)) * **source/cloudsql:** Restructure prebuilt toolsets ([googleapis#2635](googleapis#2635)) ([99613dc](googleapis@99613dc)) * **source/dataplex:** Restructure prebuilt toolsets ([googleapis#2640](googleapis#2640)) ([acb9a80](googleapis@acb9a80)) * **source/firestore:** Restructure prebuilt toolsets ([googleapis#2636](googleapis#2636)) ([22ab7b9](googleapis@22ab7b9)) * **source/oss-db:** Restructure prebuilt toolsets ([googleapis#2638](googleapis#2638)) ([5196c6a](googleapis@5196c6a)) * **source/spanner:** Restructure prebuilt toolsets ([googleapis#2641](googleapis#2641)) ([ea2b698](googleapis@ea2b698)) * Telemetry metrics updates as per semantic convention ([googleapis#2566](googleapis#2566)) ([131d764](googleapis@131d764)) * **tools/mongodb:** Add tool annotations to MongoDB tools for improved LLM understanding ([googleapis#2219](googleapis#2219)) ([b7a5f80](googleapis@b7a5f80)) * **tools/serverless-spark:** Add get_session_template tool ([googleapis#2308](googleapis#2308)) ([a136e16](googleapis@a136e16)) * **tools/serverless-spark:** Add list/get sessions tools ([googleapis#2576](googleapis#2576)) ([a554298](googleapis@a554298)) ### Bug Fixes * Improve list locks integration test for postgres ([googleapis#2279](googleapis#2279)) ([d9ebe5d](googleapis@d9ebe5d)) * **mcp:** Guard nil SSE session lookup and return 400 for missing session ([googleapis#2681](googleapis#2681)) ([f66189f](googleapis@f66189f)) * **oracle:** Update oracle-execute-sql tool interface to match source signature ([googleapis#2627](googleapis#2627)) ([81699a3](googleapis@81699a3)) * Return AllParams for GetParameter() for tools with templateParameter([googleapis#2734](googleapis#2734)) ([bfd7ba6](googleapis@bfd7ba6)) * **server/mcp:** Scope defer span.End inside loop iteration ([googleapis#2558](googleapis#2558)) ([c88a62d](googleapis@c88a62d)), closes [googleapis#2549](googleapis#2549) * **skill:** Fix env variable propagation ([googleapis#2645](googleapis#2645)) ([5271368](googleapis@5271368)) * **sources/looker:** Looker and looker-dev prebuilt tools should share one source definition. ([googleapis#2620](googleapis#2620)) ([df7f2fd](googleapis@df7f2fd)) * **telemetry:** Histogram buckets from OTel standard to MCP standards ([googleapis#2729](googleapis#2729)) ([87cd4a0](googleapis@87cd4a0)) * **ui:** Remove module from script ([googleapis#2703](googleapis#2703)) ([6943ab6](googleapis@6943ab6)) * Update toolset attributes naming ([googleapis#2554](googleapis#2554)) ([3d6ae4e](googleapis@3d6ae4e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 39832a0

🤖 I have created a release *beep* *boop* --- ## [0.29.0](googleapis/mcp-toolbox@v0.28.0...v0.29.0) (2026-03-13) ### ⚠ BREAKING CHANGES * **source/alloydb:** restructure prebuilt toolsets ([#2639](googleapis/mcp-toolbox#2639)) * **source/spanner:** restructure prebuilt toolsets ([#2641](googleapis/mcp-toolbox#2641)) * **source/dataplex:** restructure prebuilt toolsets ([#2640](googleapis/mcp-toolbox#2640)) * **source/oss-db:** restructure prebuilt toolsets ([#2638](googleapis/mcp-toolbox#2638)) * **source/cloudsql:** restructure prebuilt toolsets ([#2635](googleapis/mcp-toolbox#2635)) * **source/bigquery:** restructure prebuilt toolsets ([#2637](googleapis/mcp-toolbox#2637)) * **source/firestore:** restructure prebuilt toolsets ([#2636](googleapis/mcp-toolbox#2636)) * telemetry metrics updates as per semantic convention ([#2566](googleapis/mcp-toolbox#2566)) ### Features * Add user agent to embeddings generation ([#2572](googleapis/mcp-toolbox#2572)) ([287251a](googleapis/mcp-toolbox@287251a)) * **skill:** Attach user agent metadata for generated skill ([#2697](googleapis/mcp-toolbox#2697)) ([9598a6a](googleapis/mcp-toolbox@9598a6a)) * **skills:** Add additional-notes flag to generate skills command ([#2696](googleapis/mcp-toolbox#2696)) ([73bf962](googleapis/mcp-toolbox@73bf962)) * **skill:** Update skill generation logic ([#2646](googleapis/mcp-toolbox#2646)) ([c233eee](googleapis/mcp-toolbox@c233eee)) * **source/alloydb:** Restructure prebuilt toolsets ([#2639](googleapis/mcp-toolbox#2639)) ([5f3f063](googleapis/mcp-toolbox@5f3f063)) * **source/bigquery:** Restructure prebuilt toolsets ([#2637](googleapis/mcp-toolbox#2637)) ([dc984ba](googleapis/mcp-toolbox@dc984ba)) * **sources/bigquery:** Support custom oauth header name ([#2564](googleapis/mcp-toolbox#2564)) ([d3baf77](googleapis/mcp-toolbox@d3baf77)) * **source/cloudsql:** Restructure prebuilt toolsets ([#2635](googleapis/mcp-toolbox#2635)) ([99613dc](googleapis/mcp-toolbox@99613dc)) * **source/dataplex:** Restructure prebuilt toolsets ([#2640](googleapis/mcp-toolbox#2640)) ([acb9a80](googleapis/mcp-toolbox@acb9a80)) * **source/firestore:** Restructure prebuilt toolsets ([#2636](googleapis/mcp-toolbox#2636)) ([22ab7b9](googleapis/mcp-toolbox@22ab7b9)) * **source/oss-db:** Restructure prebuilt toolsets ([#2638](googleapis/mcp-toolbox#2638)) ([5196c6a](googleapis/mcp-toolbox@5196c6a)) * **source/spanner:** Restructure prebuilt toolsets ([#2641](googleapis/mcp-toolbox#2641)) ([ea2b698](googleapis/mcp-toolbox@ea2b698)) * Telemetry metrics updates as per semantic convention ([#2566](googleapis/mcp-toolbox#2566)) ([131d764](googleapis/mcp-toolbox@131d764)) * **tools/mongodb:** Add tool annotations to MongoDB tools for improved LLM understanding ([#2219](googleapis/mcp-toolbox#2219)) ([b7a5f80](googleapis/mcp-toolbox@b7a5f80)) * **tools/serverless-spark:** Add get_session_template tool ([#2308](googleapis/mcp-toolbox#2308)) ([a136e16](googleapis/mcp-toolbox@a136e16)) * **tools/serverless-spark:** Add list/get sessions tools ([#2576](googleapis/mcp-toolbox#2576)) ([a554298](googleapis/mcp-toolbox@a554298)) ### Bug Fixes * Improve list locks integration test for postgres ([#2279](googleapis/mcp-toolbox#2279)) ([d9ebe5d](googleapis/mcp-toolbox@d9ebe5d)) * **mcp:** Guard nil SSE session lookup and return 400 for missing session ([#2681](googleapis/mcp-toolbox#2681)) ([f66189f](googleapis/mcp-toolbox@f66189f)) * **oracle:** Update oracle-execute-sql tool interface to match source signature ([#2627](googleapis/mcp-toolbox#2627)) ([81699a3](googleapis/mcp-toolbox@81699a3)) * Return AllParams for GetParameter() for tools with templateParameter([#2734](googleapis/mcp-toolbox#2734)) ([bfd7ba6](googleapis/mcp-toolbox@bfd7ba6)) * **server/mcp:** Scope defer span.End inside loop iteration ([#2558](googleapis/mcp-toolbox#2558)) ([c88a62d](googleapis/mcp-toolbox@c88a62d)), closes [#2549](googleapis/mcp-toolbox#2549) * **skill:** Fix env variable propagation ([#2645](googleapis/mcp-toolbox#2645)) ([5271368](googleapis/mcp-toolbox@5271368)) * **sources/looker:** Looker and looker-dev prebuilt tools should share one source definition. ([#2620](googleapis/mcp-toolbox#2620)) ([df7f2fd](googleapis/mcp-toolbox@df7f2fd)) * **telemetry:** Histogram buckets from OTel standard to MCP standards ([#2729](googleapis/mcp-toolbox#2729)) ([87cd4a0](googleapis/mcp-toolbox@87cd4a0)) * **ui:** Remove module from script ([#2703](googleapis/mcp-toolbox#2703)) ([6943ab6](googleapis/mcp-toolbox@6943ab6)) * Update toolset attributes naming ([#2554](googleapis/mcp-toolbox#2554)) ([3d6ae4e](googleapis/mcp-toolbox@3d6ae4e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

… signature (googleapis#2627) ## Description This PR fixes a critical signature mismatch that caused all `oracle-execute-sql` tool invocations to fail with an incompatible source type error (`500` Internal Server Error). In a previous PR (googleapis#2323), the `RunSQL` method in the Oracle Source was updated to include a `readOnly` bool parameter to support DML operations for the `oracle-sql` tool: However, the `oracle-execute-sql` tool's required interface (`compatibleSource`) was inadvertently left unchanged, still expecting the old 3-argument signature. Because Go interfaces are satisfied implicitly, the updated Oracle source no longer implemented the `oracle-execute-sql` tool's interface, causing `tools.GetCompatibleSource` to reject it at runtime during invocation. 🛠️ Fixes googleapis#2614

🤖 I have created a release *beep* *boop* --- ## [0.29.0](googleapis/mcp-toolbox@v0.28.0...v0.29.0) (2026-03-13) ### ⚠ BREAKING CHANGES * **source/alloydb:** restructure prebuilt toolsets ([googleapis#2639](googleapis#2639)) * **source/spanner:** restructure prebuilt toolsets ([googleapis#2641](googleapis#2641)) * **source/dataplex:** restructure prebuilt toolsets ([googleapis#2640](googleapis#2640)) * **source/oss-db:** restructure prebuilt toolsets ([googleapis#2638](googleapis#2638)) * **source/cloudsql:** restructure prebuilt toolsets ([googleapis#2635](googleapis#2635)) * **source/bigquery:** restructure prebuilt toolsets ([googleapis#2637](googleapis#2637)) * **source/firestore:** restructure prebuilt toolsets ([googleapis#2636](googleapis#2636)) * telemetry metrics updates as per semantic convention ([googleapis#2566](googleapis#2566)) ### Features * Add user agent to embeddings generation ([googleapis#2572](googleapis#2572)) ([287251a](googleapis@287251a)) * **skill:** Attach user agent metadata for generated skill ([googleapis#2697](googleapis#2697)) ([9598a6a](googleapis@9598a6a)) * **skills:** Add additional-notes flag to generate skills command ([googleapis#2696](googleapis#2696)) ([73bf962](googleapis@73bf962)) * **skill:** Update skill generation logic ([googleapis#2646](googleapis#2646)) ([c233eee](googleapis@c233eee)) * **source/alloydb:** Restructure prebuilt toolsets ([googleapis#2639](googleapis#2639)) ([5f3f063](googleapis@5f3f063)) * **source/bigquery:** Restructure prebuilt toolsets ([googleapis#2637](googleapis#2637)) ([dc984ba](googleapis@dc984ba)) * **sources/bigquery:** Support custom oauth header name ([googleapis#2564](googleapis#2564)) ([d3baf77](googleapis@d3baf77)) * **source/cloudsql:** Restructure prebuilt toolsets ([googleapis#2635](googleapis#2635)) ([99613dc](googleapis@99613dc)) * **source/dataplex:** Restructure prebuilt toolsets ([googleapis#2640](googleapis#2640)) ([acb9a80](googleapis@acb9a80)) * **source/firestore:** Restructure prebuilt toolsets ([googleapis#2636](googleapis#2636)) ([22ab7b9](googleapis@22ab7b9)) * **source/oss-db:** Restructure prebuilt toolsets ([googleapis#2638](googleapis#2638)) ([5196c6a](googleapis@5196c6a)) * **source/spanner:** Restructure prebuilt toolsets ([googleapis#2641](googleapis#2641)) ([ea2b698](googleapis@ea2b698)) * Telemetry metrics updates as per semantic convention ([googleapis#2566](googleapis#2566)) ([131d764](googleapis@131d764)) * **tools/mongodb:** Add tool annotations to MongoDB tools for improved LLM understanding ([googleapis#2219](googleapis#2219)) ([b7a5f80](googleapis@b7a5f80)) * **tools/serverless-spark:** Add get_session_template tool ([googleapis#2308](googleapis#2308)) ([a136e16](googleapis@a136e16)) * **tools/serverless-spark:** Add list/get sessions tools ([googleapis#2576](googleapis#2576)) ([a554298](googleapis@a554298)) ### Bug Fixes * Improve list locks integration test for postgres ([googleapis#2279](googleapis#2279)) ([d9ebe5d](googleapis@d9ebe5d)) * **mcp:** Guard nil SSE session lookup and return 400 for missing session ([googleapis#2681](googleapis#2681)) ([f66189f](googleapis@f66189f)) * **oracle:** Update oracle-execute-sql tool interface to match source signature ([googleapis#2627](googleapis#2627)) ([81699a3](googleapis@81699a3)) * Return AllParams for GetParameter() for tools with templateParameter([googleapis#2734](googleapis#2734)) ([bfd7ba6](googleapis@bfd7ba6)) * **server/mcp:** Scope defer span.End inside loop iteration ([googleapis#2558](googleapis#2558)) ([c88a62d](googleapis@c88a62d)), closes [googleapis#2549](googleapis#2549) * **skill:** Fix env variable propagation ([googleapis#2645](googleapis#2645)) ([5271368](googleapis@5271368)) * **sources/looker:** Looker and looker-dev prebuilt tools should share one source definition. ([googleapis#2620](googleapis#2620)) ([df7f2fd](googleapis@df7f2fd)) * **telemetry:** Histogram buckets from OTel standard to MCP standards ([googleapis#2729](googleapis#2729)) ([87cd4a0](googleapis@87cd4a0)) * **ui:** Remove module from script ([googleapis#2703](googleapis#2703)) ([6943ab6](googleapis@6943ab6)) * Update toolset attributes naming ([googleapis#2554](googleapis#2554)) ([3d6ae4e](googleapis@3d6ae4e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

anubhav756 requested review from averikitsch, duwenxin99, ishatilwani1301 and kurtisvg March 4, 2026 19:55

anubhav756 self-assigned this Mar 4, 2026

anubhav756 requested a review from a team as a code owner March 4, 2026 19:55

anubhav756 force-pushed the anubhav-hotfix branch from 7944604 to c2f0a61 Compare March 4, 2026 19:55

anubhav756 added the release candidate Use label to signal PR should be included in the next release. label Mar 4, 2026

This was referenced Mar 4, 2026

fix: Revert "fix(oracle): enable DML operations and resolve incorrect array type error" #2624

Closed

Oracle oracle-execute-sql tool broken in v0.28.0 — RunSQL interface mismatch after DML fix #2614

Closed

gemini-code-assist bot reviewed Mar 4, 2026

View reviewed changes

internal/tools/oracle/oracleexecutesql/oracleexecutesql.go Outdated Show resolved Hide resolved

duwenxin99 approved these changes Mar 4, 2026

View reviewed changes

anubhav756 force-pushed the anubhav-hotfix branch from c2f0a61 to dd67eab Compare March 4, 2026 20:14

ishatilwani1301 approved these changes Mar 5, 2026

View reviewed changes

anubhav756 force-pushed the anubhav-hotfix branch from 0156299 to 94433c1 Compare March 6, 2026 05:41

anubhav756 added 3 commits March 6, 2026 16:45

fix(oracle): update oracle-execute-sql tool interface to match source…

822050f

… signature

fix(oracle): add readOnly config to oracle-execute-sql tool interface

cd3e341

test(oracle): add regression tests for oracle-execute-sql readOnly pa…

ae269ec

…rsing

anubhav756 force-pushed the anubhav-hotfix branch from 94433c1 to ae269ec Compare March 6, 2026 11:15

anubhav756 merged commit 81699a3 into main Mar 6, 2026
19 checks passed

anubhav756 deleted the anubhav-hotfix branch March 6, 2026 18:52

release-please bot mentioned this pull request Mar 6, 2026

chore(main): release 0.29.0 #2608

Merged

BrewTestBot mentioned this pull request Mar 13, 2026

mcp-toolbox 0.29.0 Homebrew/homebrew-core#272217

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(oracle): update oracle-execute-sql tool interface to match source signature#2627

fix(oracle): update oracle-execute-sql tool interface to match source signature#2627
anubhav756 merged 3 commits intomainfrom
anubhav-hotfix

anubhav756 commented Mar 4, 2026

Uh oh!

gemini-code-assist bot commented Mar 4, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

duwenxin99 left a comment

Uh oh!

anubhav756 commented Mar 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

anubhav756 commented Mar 4, 2026

Description

Uh oh!

gemini-code-assist bot commented Mar 4, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

duwenxin99 left a comment

Choose a reason for hiding this comment

Uh oh!

anubhav756 commented Mar 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants