feat(source/bigquery)!: restructure prebuilt toolsets

[averikitsch]

Description

Should include a concise description of the changes (bug or feature), it's
impact, along with a summary of the solution

PR Checklist

Thank you for opening a Pull Request! Before submitting your PR, there are a
few things you can do to make sure it goes smoothly:

• Make sure you reviewed
  CONTRIBUTING.md
• Make sure to open an issue as a
  bug/issue
  before writing your code! That way we can discuss the change, evaluate
  designs, and agree on the general idea
• Ensure the tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)
• Make sure to add ! if this involve a breaking change

🛠️ Fixes #<issue_number_goes_here>

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing the organization and maintainability of BigQuery prebuilt toolsets by splitting a monolithic toolset into two distinct, purpose-driven ones. Concurrently, it introduces a new validation step to ensure toolsets adhere to a recommended size limit, and refines existing PostgreSQL tests by re-enabling a relevant test case and removing obsolete cleanup logic. These changes aim to improve the clarity of toolset definitions and the robustness of the testing suite.

Highlights

• BigQuery Toolset Restructuring: The single bigquery_database_tools toolset has been refactored into two more focused toolsets: data and analytics, improving organization and clarity of prebuilt BigQuery tools.
• Toolset Size Validation: A new test has been introduced to log warnings for toolsets containing more than 10 tools, promoting better toolset design and manageability.
• Postgres Test Improvements: A previously disabled test case for list_schemas with an owner name has been re-enabled, and an old schema cleanup function was removed, simplifying test setup and improving test coverage.
• New Test Utility Function: A RunStatementToolsTest helper function was added to streamline the execution of tool invocation tests, making it easier to write and maintain tests for individual tools.

Changelog

• cmd/internal/tools_file_test.go
  • Updated the bigquery prebuilt tools test to reflect the new data and analytics toolsets.
  • Added a new sub-test to check and warn if any toolset exceeds 10 tools.
• internal/prebuiltconfigs/tools/bigquery.yaml
  • Replaced the bigquery_database_tools toolset with data and analytics toolsets, distributing the original tools between them.
• tests/tool.go
  • Removed the unused strconv import.
  • Re-enabled the invoke list_schemas with owner name test case.
  • Removed the cleanupOldSchemas function.
  • Simplified the schema naming convention in RunPostgresListStoredProcedureTest.
  • Modified the CREATE PROCEDURE check to be case-sensitive in RunPostgresListStoredProcedureTest.
  • Added a new helper function RunStatementToolsTest for invoking tool APIs in tests.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request restructures the BigQuery prebuilt toolsets and includes several test-related changes. The main improvement is splitting the monolithic BigQuery toolset into more focused data and analytics toolsets. I've identified a significant issue in the test code where the schema cleanup logic was removed without a replacement, which will lead to resource leaks in the test environment. My review includes a suggestion to fix this.