feat(source/oss-db)!: restructure prebuilt toolsets

[averikitsch]

Description

Should include a concise description of the changes (bug or feature), it's
impact, along with a summary of the solution

PR Checklist

Thank you for opening a Pull Request! Before submitting your PR, there are a
few things you can do to make sure it goes smoothly:

• Make sure you reviewed
  CONTRIBUTING.md
• Make sure to open an issue as a
  bug/issue
  before writing your code! That way we can discuss the change, evaluate
  designs, and agree on the general idea
• Ensure the tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)
• Make sure to add ! if this involve a breaking change

🛠️ Fixes #<issue_number_goes_here>

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the prebuilt toolset configurations for various database sources (MySQL, MSSQL, PostgreSQL). The primary goal is to improve the organization and logical grouping of tools, particularly for PostgreSQL, by introducing more granular categories. This change enhances maintainability and clarity for users interacting with these database toolsets, while also adding a new validation for toolset sizes.

Highlights

• Toolset Restructuring: Prebuilt toolsets for MySQL, MSSQL, and PostgreSQL database sources have been restructured for improved organization.
• PostgreSQL Tool Categorization: PostgreSQL tools are now categorized into 'data', 'monitor', 'optimize', and 'config' toolsets, replacing a single large toolset.
• Simplified MySQL and MSSQL Toolsets: MySQL and MSSQL toolsets have been simplified to a single 'data' category.
• Toolset Size Validation: A new test has been introduced to warn if any toolset exceeds a recommended maximum of 10 tools, promoting modularity.
• Test Case Re-enablement: A previously commented-out test case for PostgreSQL list_schemas functionality, specifically filtering by owner name, has been re-enabled.

Changelog

• cmd/internal/tools_file_test.go
  • Updated expected toolset names from database-specific names (e.g., mysql_database_tools) to generic data for MySQL and MSSQL.
  • Refactored the single postgres_database_tools into multiple distinct toolsets (data, monitor, optimize, config) with specific tool assignments.
  • Added a new sub-test to check and log warnings for toolsets exceeding a recommended size of 10 tools.
• internal/prebuiltconfigs/tools/mssql.yaml
  • Renamed the mssql_database_tools toolset to data.
• internal/prebuiltconfigs/tools/mysql.yaml
  • Renamed the mysql_database_tools toolset to data.
• internal/prebuiltconfigs/tools/postgres.yaml
  • Restructured the single postgres_database_tools into four new toolsets: data, monitor, optimize, and config, each containing a subset of the original tools.
  • Removed extraneous blank lines within the tools section.
• tests/tool.go
  • Removed the unused strconv import.
  • Re-enabled the list_schemas test case that filters by owner name.
  • Removed the cleanupOldSchemas helper function.
  • Modified the schema naming convention and removed timestamp dependency in RunPostgresListStoredProcedureTest.
  • Updated the CREATE PROCEDURE check to be case-sensitive.
  • Added a new helper function RunStatementToolsTest for running multiple tool invocation tests.

Activity

• The author created the pull request with a description outlining the changes and a PR checklist.
• The PR checklist indicates items to be reviewed, including CONTRIBUTING.md, opening an issue, passing tests/linter, code coverage, and docs.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the prebuilt toolsets for OSS databases (MySQL, MSSQL, and PostgreSQL) to be more modular. The most significant change is for PostgreSQL, where a single large toolset has been broken down into smaller, more manageable ones: data, monitor, optimize, and config. This is a positive change for usability. The tests have been updated accordingly, including a new check to warn if toolsets exceed a recommended size. My review includes a suggestion to improve test logging and raises a concern about the removal of a test cleanup function, which could potentially lead to resource leaks.

I am having trouble creating individual review comments. Click here to see my feedback.

tests/tool.go (4421-4458)

The cleanupOldSchemas function and its call have been removed. This function was responsible for cleaning up test schemas older than one hour, which is a good practice to prevent resource leakage in long-running test environments. Its removal could lead to an accumulation of stale resources, potentially causing test flakiness or increased costs. If this cleanup is now handled by another mechanism (e.g., CI environment teardown), it would be beneficial to add a comment explaining that. Otherwise, please consider restoring this or a similar cleanup logic.

cmd/internal/tools_file_test.go (1980-1981)

The use of fmt.Printf is redundant as t.Logf already logs the warning to the test output. Using fmt.Printf writes directly to standard output, which is generally discouraged in tests as it can create noise and bypasses the test runner's output management. Please remove the redundant fmt.Printf call.

                                                t.Logf("WARNING: Toolset %q in config %q has %d tools, which is larger than the recommended maximum of 10.", tsName, tc.name, len(ts.ToolNames))

[averikitsch]

/gemini review

[gemini-code-assist]

Code Review

This pull request refactors the prebuilt toolsets for MySQL, MSSQL, and PostgreSQL by breaking down large, monolithic toolsets into smaller, more focused ones (e.g., data, monitor, health). This is a significant improvement for usability and aligns with the best practice of keeping toolsets small. The changes are consistently applied across the YAML configuration files and their corresponding tests. The addition of a new test to warn about toolsets exceeding a recommended size is a great proactive measure to maintain this new standard going forward. I have one minor suggestion regarding naming consistency for one of the new toolsets to further improve the codebase.