Use prefiltered radiance for Sky high quality update mode#58177
Merged
akien-mga merged 1 commit intoFeb 17, 2022
Conversation
JFonS
approved these changes
Feb 16, 2022
Member
|
The class reference needs an update for the new default values. |
055d72e to
f697262
Compare
f697262 to
48728a7
Compare
Member
Author
|
Pushed changes that allow the mobile renderer to benefit from the prefiltering and I pulled some calculations out of the loop to improve performance slightly. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #43763
The first of the improvements discussed #43763 (comment)
This PR substantially improves the quality of the high quality update mode and improves the performance (from ~60ms per frame to ~5ms per frame on my device). High Quality mode is still not suitable for updating every frame, but the incremental mode is now faster than the real time mode making it the most suitable for updates in the editor (Once this is merged we can revert #57931 and #58165 and allow skys to default to "automatic mode").
Further, High Quality/Incremental can be made very fast by setting the radiance size to 128 (which is the default size in many other engines) or by disabling "use_arrays" in the project settings. With a radiance size of 128, high quality mode takes the same amount of time to update as Realtime at 256. So Realtime is still the preferred choice when updating every frame, but the performance quality tradeoff is more even now
Photo comparison
Using 1024 samples (~65ms):

Using 32 samples (~5ms):

Old version using 32 samples (~4ms):

Old version with 1024 samples (~60ms):
