Default to real-time radiance map filter for environment sky reflections#57931
Merged
akien-mga merged 1 commit intoFeb 15, 2022
Merged
Conversation
This makes radiance map updates much faster, which improves performance when rotating the sun in the editor or at run-time. This real-time filter is also much less prone to "fireflies" that can appear when using a sky with a bright sun.
clayjohn
approved these changes
Feb 15, 2022
Member
clayjohn
left a comment
clayjohn
left a comment
There was a problem hiding this comment.
Looks good for now.
We should revisit this once we implement the optimizations discussed in #58086. I'd like to make the Automatic mode the default again before we release 4.0.
The Automatic mode is really handy for users, and I think the Incremental mode will be fine once we get the base cost of the high quality filtering down. In theory, incremental can be made to be even cheaper than real time (because it is spread over many frames
Member
|
Thanks! |
This was referenced Feb 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can be merged independently of #55933.
This makes radiance map updates much faster, which improves performance when rotating the sun in the editor or at run-time.
This real-time filter is also much less prone to "fireflies" that can appear when using a sky with a bright sun.
This was discussed in a PR meeting and we agreed upon having this setting as the default 🙂
Example with this HDRI:
Before
After