Skip to content

Fix default sky process mode not being Real-Time#58165

Merged
akien-mga merged 1 commit into
godotengine:masterfrom
Calinou:fix-default-sky-process-mode
Feb 16, 2022
Merged

Fix default sky process mode not being Real-Time#58165
akien-mga merged 1 commit into
godotengine:masterfrom
Calinou:fix-default-sky-process-mode

Conversation

@Calinou
Copy link
Copy Markdown
Member

@Calinou Calinou commented Feb 16, 2022

Follow-up to #57931.

The change in 09563e4 wasn't consistently carried out everywhere needed. This led to the sky mode still being Automatic by default, even if the default option in the inspector was Real-Time.

The change in 09563e4 wasn't
consistently carried out everywhere needed.
@Calinou Calinou requested a review from a team as a code owner February 16, 2022 00:53
@Calinou Calinou added this to the 4.0 milestone Feb 16, 2022
@fire
Copy link
Copy Markdown
Member

fire commented Feb 16, 2022

Making the change consistent keeps the design intact and this appears to make the design consistent. Sounds good.

@akien-mga akien-mga merged commit 7989149 into godotengine:master Feb 16, 2022
@Calinou Calinou deleted the fix-default-sky-process-mode branch February 16, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants