Use full size mipmaps for reflections when in high-quality mode#62362
Merged
Conversation
Member
Author
|
@lyuma I'd appreciate it if you could test this out in your project as you were the one to first notice the issue and it was most obvious in your project |
akien-mga
approved these changes
Jul 27, 2022
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #61511
As suspected the issue was caused by using a 64x64 mipmap (introduced in #58177). This bug also caused high-quality skies to look worse than realtime skies again. With this PR, they are back to looking about the same.
High Quality mode is now slightly slower than it was after merging #58177, but it is still significantly faster than before #58177. (On my device this PR adds about 150 us for the calculation of high-quality reflections out of ~5 ms for the full sky update).
Before
After
