Wayland: Allow non-interactive window resizing #114082
Merged
+137
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite what I thought in the past, it is allowed, as long as we follow certain limitations depending on the toplevel's state. As usual I peppered the code with comments expaining what those limitations are. Regarding popups, AFAICT there are no major limitations, although we should eventually use the new `reposition` method, which autoadjusts the popup to follow the screen's borders and whatnot. I didn't do that in this patch as it requires some elbow grease, especially if we want to do it synchronously.
Contributor
Author
|
Oops, rebased wrong branch. No edits made. |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #114081.
Might fix #94157.
Fixes #111700 (comment).
Despite what I thought in the past, it is allowed, as long as we follow certain limitations depending on the toplevel's state.
As usual I peppered the code with comments expaining what those limitations are.
Regarding popups, AFAICT there are no major limitations, although we should eventually use the new
repositionmethod, which autoadjusts the popup to follow the screen's borders and whatnot. I didn't do that in this patch as it requires some elbow grease, especially if we want to do it synchronously.Includes some teeny tiny fixes to two mistakes:
text-input-unstable-v3.Also needs more testing. It definitely fixes the issues reported in #111700 (comment) , which is already something :D