Skip to content

Make remote debug elements ignore the canvas scaling#111700

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
YeldhamDev:ignore_scale_remote_debug
Dec 15, 2025
Merged

Make remote debug elements ignore the canvas scaling#111700
Repiteo merged 1 commit intogodotengine:masterfrom
YeldhamDev:ignore_scale_remote_debug

Conversation

@YeldhamDev
Copy link
Member

Supersedes #98984.

@YeldhamDev YeldhamDev added this to the 4.x milestone Oct 16, 2025
@YeldhamDev YeldhamDev requested a review from a team as a code owner October 16, 2025 00:07
@KoBeWi
Copy link
Member

KoBeWi commented Nov 30, 2025

Not sure what issue does this try to fix. I'm seeing the same results with and without this change.

@YeldhamDev
Copy link
Member Author

Increase the value of display/window/stretch/scale in the Project Settings to 2. Without this, both the selection square and popup will be bigger as well.

However, something broke after this PR was created, and it doesn't shrink the popup's size anymore. Will investigate why.

@YeldhamDev
Copy link
Member Author

Correction, it seems to not be shrinking only on Wayland, but it does on X11, odd...
CC @deralmas could you help shed a light on this?

@deralmas
Copy link
Contributor

Hi, I think that this might be related to the embedder, as the behavior looks good on a "bare" window (completely unembedded, not even floating workspace). It indeed looks kinda broken when the game is embedded.

That's kinda weird though, as the only thing we adjust in popup messages is the position, not the size. I'll take a closer look as soon as I can.

That said, this issue seems unrelated to this PR itself and thus I don't think that it's blocking.

@YeldhamDev YeldhamDev force-pushed the ignore_scale_remote_debug branch from c4a3c5e to 33c2ce5 Compare December 1, 2025 20:44
@Repiteo Repiteo modified the milestones: 4.x, 4.6 Dec 15, 2025
@Repiteo Repiteo merged commit 8c4e793 into godotengine:master Dec 15, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 15, 2025

Thanks!

@YeldhamDev YeldhamDev deleted the ignore_scale_remote_debug branch December 15, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants