Skip to content

Conversation

@deralmas
Copy link
Contributor

@deralmas deralmas commented Dec 16, 2025

Freshly released. (previously a version "update" but it looks like the wrapper was just outdated)

Exposes two new methods, which return the min/max size that we should send. The difference is that this data can be dynamically set by the currently running decoration plugin, and useful for a patch I'm testing.

I regenerated the dynwrap with a slightly patched dynload-wrapper (I'll make a PR there hpvb/dynload-wrapper#7), as otherwise it broke a single method signature for a very stupid reason. We now use the same switches as other dependencies, pointing to the thirdparty headers directory and generating the wrappers directly into their path.

@deralmas deralmas added this to the 4.6 milestone Dec 16, 2025
@deralmas deralmas requested review from a team as code owners December 16, 2025 17:06

- Upstream: https://gitlab.freedesktop.org/libdecor/libdecor/
- Version: 0.2.2
- Version: 0.2.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any actual changes to the headers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, it looks like the headers are indeed the same. Looks like that the dynwrap was outdated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps I could reword the PR to say "regenerate dynamic wrapper" or something like that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@deralmas
Copy link
Contributor Author

Wait I haven't reworded the commit yet 😅

@akien-mga
Copy link
Member

Yeah I can wait for that, though it's not a big deal either way.

@deralmas deralmas force-pushed the thirdparty/libdecor/0.2.5 branch from 0ee5af5 to bea572f Compare December 17, 2025 12:14
@deralmas deralmas changed the title libdecor: Update to 0.2.5 libdecor: Regenerate dynamic wrapper Dec 17, 2025
@deralmas
Copy link
Contributor Author

Reworded the thing. I've kept the change in version as it's technically also that, dunno if I should get rid of those changes.

(oof a whole CI rebuild for a commit description change is annoying, sorry about that)

@akien-mga
Copy link
Member

Yeah keeping the version change is good, technically it's correct, and that prevents us from thinking we're still lagging behind upstream.

@akien-mga akien-mga merged commit 0509500 into godotengine:master Dec 17, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants