Wayland: Add missing destroy calls for text input and tablet#113947
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Dec 16, 2025
Merged
Wayland: Add missing destroy calls for text input and tablet#113947akien-mga merged 1 commit intogodotengine:masterfrom
akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
Thank you Kiisu_Master for finding this!
bruvzg
approved these changes
Dec 16, 2025
| zwp_tablet_tool_v2_destroy(tool); | ||
| } | ||
|
|
||
| zwp_text_input_v3_destroy(ss->wp_text_input); |
Member
There was a problem hiding this comment.
Probably should have null check, even if it's expected to be always initialized:
Suggested change
| zwp_text_input_v3_destroy(ss->wp_text_input); | |
| if (ss->wp_text_input) { | |
| zwp_text_input_v3_destroy(ss->wp_text_input); | |
| } |
Member
There was a problem hiding this comment.
Oops I merged without seeing this comment.
Probably worth adding in a future PR updating wayland_thread.cpp.
Contributor
Author
There was a problem hiding this comment.
Absolutely, as I think that this might actually be a null dereference on platforms without it wp_text_input_support.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you Kiisu_Master for finding this!
This is very easy to mess up. In the end, I think I'm actually going to figure out how to unify the logic, despite avoiding doing that for so long.
Cherry-pickable to 4.5.