Skip to content

Add WebKit to e2e test matrix#37298

Merged
silverwind merged 7 commits intogo-gitea:mainfrom
silverwind:e2e-webkit
Apr 19, 2026
Merged

Add WebKit to e2e test matrix#37298
silverwind merged 7 commits intogo-gitea:mainfrom
silverwind:e2e-webkit

Conversation

@silverwind
Copy link
Copy Markdown
Member

@silverwind silverwind commented Apr 19, 2026 •
edited
Loading

Verified locally with 50 runs, averaging 9 seconds per local test suite run. Total suite took 15s.

--with-deps is needed because webkit's dependencies are not pre-installed on GHA runners (as opposed to firefox/chrome which are preinstalled).

This PR was written with the help of Claude Opus 4.7

@silverwind @claude
Add webkit (Safari) to e2e test browsers
8288b91 
Extends the Playwright project matrix to run against WebKit in addition
to Chromium and Firefox, catching Safari-only regressions. GitHub Actions
Ubuntu runners already ship WebKit's system deps preinstalled, so no
workflow changes are needed.

Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 19, 2026
@silverwind @claude
Link Playwright system requirements from CONTRIBUTING
18f00b8 
Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
@silverwind @claude
Remove Playwright system requirements link from CONTRIBUTING
d2b5440 
Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
silverwind and others added 2 commits April 19, 2026 17:09
@silverwind @claude
Install WebKit system deps on CI
d8c4269 
GitHub Actions Ubuntu runners preinstall Chromium/Firefox deps but not
WebKit's (gtk4, gstreamer, flite, etc.), so webkit needs --with-deps.
Runners provide passwordless sudo, which Playwright uses internally.

Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
@silverwind @claude
Collapse playwright install to a single line
97585d5 
Always pass --with-deps. The previous conditional skipped it on CI to
avoid a redundant sudo apt-get, but webkit's deps aren't preinstalled
on Ubuntu runners, so --with-deps is needed there anyway. The extra
apt-get call for already-installed chromium/firefox deps is cheap.

Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
@silverwind
Copy link
Copy Markdown
Member Author

silverwind commented Apr 19, 2026

Works, CI failure is pre-existing and needs #37297.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 19, 2026
@silverwind silverwind changed the title Add WebKit (Safari) to e2e test browsers Add WebKit to e2e test browsers Apr 19, 2026
@silverwind silverwind changed the title Add WebKit to e2e test browsers Add WebKit to e2e test matrix Apr 19, 2026
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 19, 2026
@silverwind silverwind enabled auto-merge (squash) April 19, 2026 18:45
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 19, 2026
@silverwind silverwind disabled auto-merge April 19, 2026 18:49
@silverwind silverwind enabled auto-merge (squash) April 19, 2026 18:49
@silverwind silverwind merged commit 6f76121 into go-gitea:main Apr 19, 2026
26 checks passed
@silverwind silverwind deleted the e2e-webkit branch April 19, 2026 19:09
@GiteaBot GiteaBot added this to the 1.27.0 milestone Apr 19, 2026
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 19, 2026
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 20, 2026
@zjjhot
Merge branch 'main' into mainzjj
b8a140c 
* main: (25 commits)
  Add WebKit to e2e test matrix (go-gitea#37298)
  Don't add useless labels which will bother changelog generation (go-gitea#37267)
  Fix Repository transferring page (go-gitea#37277)
  Stabilize issue-project e2e test, increase timeout factor (go-gitea#37297)
  Fix Mermaid diagrams failing when node labels contain line breaks (go-gitea#37296)
  Add project column picker to issue and pull request sidebar (go-gitea#37037)
  Fix container auth for public instance (go-gitea#37290)
  Refactor frontend `tw-justify-between` layouts to `flex-left-right` (go-gitea#37291)
  Update Nix flake (go-gitea#37284)
  Workflow Artifact Info Hover (go-gitea#37100)
  [skip ci] Updated translations via Crowdin
  release notes for 1.26.0 (go-gitea#37282)
  Enhance GetActionWorkflow to support fallback references (go-gitea#37189)
  Refactor LDAP tests (go-gitea#37274)
  Remove `SubmitEvent` polyfill (go-gitea#37276)
  Upgrade go-git to v5.18.0 (go-gitea#37268)
  Avoid top-level await (go-gitea#37272)
  Frontend iframe renderer framework: 3D models, OpenAPI (go-gitea#37233)
  pull: Fix CODEOWNERS absolute path matching. (go-gitea#37244)
  Swift registry metadata: preserve more JSON fields and accept empty metadata (go-gitea#37254)
  ...
silverwind added a commit to silverwind/gitea that referenced this pull request Apr 20, 2026
@silverwind @claude
Revert "Add WebKit to e2e test matrix (go-gitea#37298)"
fb23884 
This reverts commit 6f76121.

WebKit on Linux has a long history of flakiness in Playwright CI runs,
with the exact "WebKit encountered an internal error" class of failures
repeatedly reported and closed without a real fix (typically as
stale/no-repro, or worked around by retries). See:

- microsoft/playwright#34450
- microsoft/playwright#35773
- microsoft/playwright#35870
- microsoft/playwright#35293
- microsoft/playwright#38838

Keep chromium and firefox in the e2e matrix.

Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
@silverwind silverwind mentioned this pull request Apr 20, 2026
Merged
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 20, 2026
techknowlogick pushed a commit that referenced this pull request Apr 20, 2026
@silverwind @claude
Revert "Add WebKit to e2e test matrix (#37298)" (#37315)
b6ea666 
Reverts: #37298
Ref:
https://github.com/go-gitea/gitea/actions/runs/24661464168/job/72108324223?pr=37312

WebKit on Linux has a long history of flakiness in Playwright CI runs,
and the exact "WebKit encountered an internal error" class of failures
has been reported repeatedly and closed without a real fix (typically
stale/no-repro, or worked around by retries):

- microsoft/playwright#34450
- microsoft/playwright#35773
- microsoft/playwright#35870
- microsoft/playwright#35293
- microsoft/playwright#38838

Keeping chromium and firefox in the e2e matrix.

---
This PR was written with the help of Claude Opus 4.7

Co-authored-by: Claude (Opus 4.7) <noreply@anthropic.com>
@silverwind
Copy link
Copy Markdown
Member Author

silverwind commented Apr 20, 2026

Was reverted, see #37315 (comment) for details.

silverwind added a commit to silverwind/gitea that referenced this pull request Apr 20, 2026
@silverwind
Merge remote-tracking branch 'origin/main' into relative-time-invalid…
03ebb69 
…-lang

* origin/main:
  Update go js dependencies (go-gitea#37312)
  Update GitHub Actions to latest major versions (go-gitea#37313)
  Revert "Add WebKit to e2e test matrix (go-gitea#37298)" (go-gitea#37315)
  Add `form-fetch-action` to some forms, fix "fetch action" resp bug (go-gitea#37305)
  Move heatmap to first-party code (go-gitea#37262)
  Use updated yaml fields for snapcraft (go-gitea#37318)
  Remove dead code identified by `deadcode` tool (go-gitea#37271)
  Enable strict TypeScript, add `errorMessage` helper (go-gitea#37292)
  Fix vite manifest update masking build errors (go-gitea#37279)
  bump snapcraft base (go-gitea#37301)

# Conflicts:
#	web_src/js/modules/errors.ts
silverwind added a commit to 6543-forks/gitea that referenced this pull request Apr 21, 2026
@silverwind
Merge remote-tracking branch 'origin/main' into ux-package-deb-explai…
4d4ddf7 
…n-better

* origin/main: (645 commits)
  When the requested arch rpm is missing fall back to noarch (go-gitea#37236)
  Fix `relative-time` error and improve global error handler (go-gitea#37241)
  Enhance styling in actions page (go-gitea#37323)
  fix(oauth): Error on auth sources with spaces (go-gitea#37327)
  Fix actions concurrency groups cross-branch leak (go-gitea#37311)
  Fix bug when accessing user badges (go-gitea#37321)
  Fix AppFullLink (go-gitea#37325)
  Update go js dependencies (go-gitea#37312)
  Update GitHub Actions to latest major versions (go-gitea#37313)
  Revert "Add WebKit to e2e test matrix (go-gitea#37298)" (go-gitea#37315)
  Add `form-fetch-action` to some forms, fix "fetch action" resp bug (go-gitea#37305)
  Move heatmap to first-party code (go-gitea#37262)
  Use updated yaml fields for snapcraft (go-gitea#37318)
  Remove dead code identified by `deadcode` tool (go-gitea#37271)
  Enable strict TypeScript, add `errorMessage` helper (go-gitea#37292)
  Fix vite manifest update masking build errors (go-gitea#37279)
  bump snapcraft base (go-gitea#37301)
  Add WebKit to e2e test matrix (go-gitea#37298)
  Don't add useless labels which will bother changelog generation (go-gitea#37267)
  Fix Repository transferring page (go-gitea#37277)
  ...

# Conflicts:
#	options/locale/locale_en-US.ini
#	templates/package/content/debian.tmpl
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 22, 2026
@zjjhot
Merge branch 'main' into mainzjj
bfef37f 
* main: (25 commits)
  Add URL to `Learn more about blocking a user` (go-gitea#37355)
  fix: use TriggerEvent instead of Event in workflow runs API response for scheduled runs (go-gitea#37288)
  Add event.schedule context for schedule actions task (go-gitea#37320)
  Fix typos (go-gitea#37346)
  Fix an issue where changing an organization’s visibility caused problems when users had forked its repositories. (go-gitea#37324)
  Fail vite build on rolldown warnings via NODE_ENV=test (go-gitea#37270)
  Use modern "git update-index --cacheinfo" syntax to support more file names (go-gitea#37338)
  Fix URL related escaping for oauth2 (go-gitea#37334)
  When the requested arch rpm is missing fall back to noarch (go-gitea#37236)
  Fix `relative-time` error and improve global error handler (go-gitea#37241)
  Enhance styling in actions page (go-gitea#37323)
  fix(oauth): Error on auth sources with spaces (go-gitea#37327)
  Fix actions concurrency groups cross-branch leak (go-gitea#37311)
  Fix bug when accessing user badges (go-gitea#37321)
  Fix AppFullLink (go-gitea#37325)
  Update go js dependencies (go-gitea#37312)
  Update GitHub Actions to latest major versions (go-gitea#37313)
  Revert "Add WebKit to e2e test matrix (go-gitea#37298)" (go-gitea#37315)
  Add `form-fetch-action` to some forms, fix "fetch action" resp bug (go-gitea#37305)
  Move heatmap to first-party code (go-gitea#37262)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunny lunny lunny approved these changes

@bircni bircni bircni approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/testing

Projects

None yet

Milestone

1.27.0

Development

Successfully merging this pull request may close these issues.

4 participants

@silverwind @lunny @bircni @GiteaBot