Refactor frontend tw-justify-between layouts to flex-left-right#37291
Refactor frontend tw-justify-between layouts to flex-left-right#37291wxiaoguang merged 5 commits intomainfrom
tw-justify-between layouts to flex-left-right#37291Conversation
Co-Authored-By: Copilot GPT-5.4 <copilot-gpt-5-4@users.noreply.github.com> Agent-Logs-Url: https://github.com/go-gitea/gitea/sessions/60f35335-afaf-4bcf-a4cf-db8e42203c61 Co-authored-by: wxiaoguang <2114189+wxiaoguang@users.noreply.github.com>
GiteaBot
added
the
lgtm/need 2
GiteaBot
added
lgtm/need 1
GiteaBot
added
lgtm/done
|
This may be fine, but generally I'm against adding/using any more such "helper classes" because they are hard to discover and reason about. Tailwind's classes are more verbose, but don't make me have to go look up in CSS what a class actually does. I prefer simple 1:1 classes. |
You mean you will keep writing |
|
Yes, I can fully understand what this does by just looking at the HTML only and this is the main reason tailwindcss is so popular. It avoids having to context-switch into CSS. It's never clear-cut when a CSS class is better over tailwind, but I think ~5 classes on a element is not a problem. |
|
There are also enough people against for the excessively used tailwind helper classes. I believe there should be a balance, use it, but don't abuse it. Just like AI |
* 'cast' of github.com:silverwind/gitea: Fix Mermaid diagrams failing when node labels contain line breaks (go-gitea#37296) Add project column picker to issue and pull request sidebar (go-gitea#37037) Fix container auth for public instance (go-gitea#37290) Refactor frontend `tw-justify-between` layouts to `flex-left-right` (go-gitea#37291) Update Nix flake (go-gitea#37284) Workflow Artifact Info Hover (go-gitea#37100)
* main: (25 commits) Add WebKit to e2e test matrix (go-gitea#37298) Don't add useless labels which will bother changelog generation (go-gitea#37267) Fix Repository transferring page (go-gitea#37277) Stabilize issue-project e2e test, increase timeout factor (go-gitea#37297) Fix Mermaid diagrams failing when node labels contain line breaks (go-gitea#37296) Add project column picker to issue and pull request sidebar (go-gitea#37037) Fix container auth for public instance (go-gitea#37290) Refactor frontend `tw-justify-between` layouts to `flex-left-right` (go-gitea#37291) Update Nix flake (go-gitea#37284) Workflow Artifact Info Hover (go-gitea#37100) [skip ci] Updated translations via Crowdin release notes for 1.26.0 (go-gitea#37282) Enhance GetActionWorkflow to support fallback references (go-gitea#37189) Refactor LDAP tests (go-gitea#37274) Remove `SubmitEvent` polyfill (go-gitea#37276) Upgrade go-git to v5.18.0 (go-gitea#37268) Avoid top-level await (go-gitea#37272) Frontend iframe renderer framework: 3D models, OpenAPI (go-gitea#37233) pull: Fix CODEOWNERS absolute path matching. (go-gitea#37244) Swift registry metadata: preserve more JSON fields and accept empty metadata (go-gitea#37254) ...
This PR standardizes left/right two-child frontend layouts on
flex-left-rightand removes ad-hoctw-justify-betweencombinations. The goal is consistent wrapping + spacing behavior under narrow widths with less utility-class churn.Also: remove useless "flex-center-wrap", slightly improve some templates (no visual change, tested)
Authorship attribution: Copilot (GPT-5.4)