Workflow Artifact Info Hover by bircni · Pull Request #37100 · go-gitea/gitea

bircni · 2026-04-03T21:40:45Z

Add expiry metadata to action artifacts in the run view and show it on hover.

silverwind · 2026-04-03T22:48:35Z

Can you add the hover over the actual link, not the parent div? That way the triangle of the tooltip should be aligned correctly and not point to nothing.

bircni · 2026-04-04T09:48:26Z

Can you add the hover over the actual link, not the parent div? That way the triangle of the tooltip should be aligned correctly and not point to nothing.

I tried, it is currently at the link but it somehow doesnt work - Could you help me? @silverwind

silverwind · 2026-04-04T15:49:38Z

I think you can just produce the <relative-time> element in JS. tippy is capable of HTML tooltip content via an option, called html=true iirc.

- Use relative-time element for date formatting in tooltip - Extract formatFileSize to shared utility web_src/js/utils/size.ts - Remove custom Intl.DateTimeFormat, ArtifactTooltipLocale type, Size label - Use createTippy with DOM element content via ref callback - Use muted link style for active artifacts, faded style for expired - Add semibold to sidebar section headings - Skip tooltip on expired artifacts - Disable tooltip arrow, use top-end placement Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

silverwind · 2026-04-09T20:07:44Z

Did a number of tweaks and fixes, now using relative-time:

Move vertical padding from li to first-child so the link covers the full row height. Reduce tooltip offset to 2px. Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

silverwind · 2026-04-09T20:15:48Z

Also one notable change: Expired artifacts don't show a tooltip. I noticed the DB apparently stores the size of expired artifacts but imho it's a rarely useful and confusing info to display size of a expired artifact.

Also backport as a no-risk enhancement.

- Move formatBytes (renamed from formatFileSize) into web_src/js/utils.ts - Remove web_src/js/utils/size.ts - Move artifact li padding to first-child for full-height click area - Reduce tooltip offset to 2px Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

Copilot

Pull request overview

Adds artifact expiry metadata (and size) to the Actions run view and displays it as a hover tooltip in the sidebar artifact list, backed by new backend fields and frontend formatting helpers.

Changes:

Extend backend artifact metadata to include expired_unix and expose it as expiresUnix in the actions run view response.
Add frontend tooltip generation for artifacts (expiry via <relative-time> + formatted size).
Introduce a shared formatBytes() utility and corresponding unit tests; add new locale key for “Expires at %s”.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
web_src/js/utils.ts	Adds `formatBytes()` helper for human-readable artifact sizes.
web_src/js/utils.test.ts	Adds unit tests for `formatBytes()`.
web_src/js/modules/gitea-actions.ts	Extends `ActionsArtifact` type with `size` and `expiresUnix`.
web_src/js/features/repo-actions.ts	Wires new locale string (`artifactExpiresAt`) into the Vue view props.
web_src/js/components/RepoActionView.vue	Attaches artifact hover tooltips and adjusts artifact list styling.
web_src/js/components/ActionRunArtifacts.ts	Implements tooltip element creation (expiry + size).
web_src/js/components/ActionRunArtifacts.test.ts	Adds unit tests for tooltip element creation.
templates/repo/actions/view_component.tmpl	Adds `data-locale-artifact-expires-at` for the run view.
templates/devtest/relative-time.tmpl	Adds a devtest example including minute-level formatting.
routers/web/repo/actions/view.go	Adds `expiresUnix` to artifacts JSON returned by the run view endpoint.
routers/web/devtest/mock_actions.go	Populates mock artifacts with `ExpiresUnix` values for devtest.
options/locale/locale_en-US.json	Adds `artifact_expires_at` locale string.
models/actions/artifact.go	Includes `expired_unix` in grouped artifact meta query results.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- encodeURIComponent on artifact download href for names with spaces or special characters - Use minute='2-digit' on relative-time for consistent zero-padding Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

- Replace text pipe with border-left separator via Tailwind classes - Remove flexbox on tooltip container to preserve whitespace between locale text and relative-time element - Fix empty line at end of style block Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

wxiaoguang · 2026-04-19T05:44:30Z

Mock real world case, don't trigger Vue reactive refresh every second: alignTime
Mock "size only" tooltip: ExpiresUnix: 0,
Always use html prefix in buildArtifactTooltipHtml to avoid potential XSS (someone might forget in the future)
Construct the HTML content with tags, but not string concatenation
Add text content for relative-time
Make the design more flexible by data-tooltip-render="html" but not data-tooltip-render-html="true"
Also add aria-label even if the content is HTML

wxiaoguang · 2026-04-19T06:14:00Z

Test what you need clearly and explicitly, but not use not or contains to guess.

bircni · 2026-04-19T07:05:45Z

thanks @wxiaoguang

silverwind · 2026-04-19T10:11:29Z

@wxiaoguang not sure the reason for the force-push but should be avoided to force-pushing over other people's commits. The only legitimate reason to force push on a pull request branch is to force-push over your own commits.

wxiaoguang · 2026-04-19T10:13:28Z

@wxiaoguang don't force-push onto PR branches unless you are force-pushing over your own commits, GitHub still shows what you did

These 2 force-pushes are just in short time, no one is working on it, and it doesn't affect review, the result is still clean and correct, so what's the problem or what's wrong?

wxiaoguang · 2026-04-19T10:14:10Z

The only legitimate reason to force push on a pull request branch is to force-push over your own commits.

Yes, I only force-pushed my own commits, what's the problem and what's wrong?

silverwind · 2026-04-19T10:18:45Z

+        ${datetime}
+      </relative-time>
+      <span>${suffix}</span>
+      <span class="inline-divider">,</span>


I'm against , separator, it is inconsistent with file view header which uses | and I think | is better.

Is it your guess? Have you read the code or tested it?

Don't you see it still shows "|" ?

Ah I see what you did. Should apply that to file view too and ideally add a font-size: 0 to hide the original text entirely.

silverwind · 2026-04-19T10:20:30Z

Yes, I only force-pushed my own commits, what's the problem and what's wrong?

That's fine but in the past you were force-pushing over my commits so I'm skeptical.

wxiaoguang · 2026-04-19T10:21:48Z

Yes, I only force-pushed my own commits, what's the problem and what's wrong?

That's fine but in the past you were force-pushing over my commits so I'm skeptical.

When? What problem it ever caused?

The last time I force-pushed the commit to revert the incorrect CSP code (AI slop with made a lot of nonsense changes to the swagger internals). And I had told you ahead at that time that I would revert the unrelated changes.

So, I know what I am doing. If you found what I did is wrong, point it directly for the case, don't guess

wxiaoguang · 2026-04-19T10:23:10Z

I'm skeptical.

More than 99% of your guesses of my code or my decisions are all wrong. See the PR history and discussions.

silverwind · 2026-04-19T10:25:54Z

It was still surprising to me when you did. You could have achieved the same without a force-push.

wxiaoguang · 2026-04-19T10:28:23Z

It was still surprising to me when you did. You could have achieved the same without a force-push.

But when you said that you have removed the AI slop, the slop is still there, why you can't make it right? I just saw the completely messy commits then I decided to force push. Why I should waste more time on the AI slop.

silverwind · 2026-04-19T10:32:25Z

Even if deemed bad, no reason to force-push over other's people's commits imho. Either cleanly revert with "git revert" or do the fixup directly.

* 'cast' of github.com:silverwind/gitea: Fix Mermaid diagrams failing when node labels contain line breaks (go-gitea#37296) Add project column picker to issue and pull request sidebar (go-gitea#37037) Fix container auth for public instance (go-gitea#37290) Refactor frontend `tw-justify-between` layouts to `flex-left-right` (go-gitea#37291) Update Nix flake (go-gitea#37284) Workflow Artifact Info Hover (go-gitea#37100)

* main: (25 commits) Add WebKit to e2e test matrix (go-gitea#37298) Don't add useless labels which will bother changelog generation (go-gitea#37267) Fix Repository transferring page (go-gitea#37277) Stabilize issue-project e2e test, increase timeout factor (go-gitea#37297) Fix Mermaid diagrams failing when node labels contain line breaks (go-gitea#37296) Add project column picker to issue and pull request sidebar (go-gitea#37037) Fix container auth for public instance (go-gitea#37290) Refactor frontend `tw-justify-between` layouts to `flex-left-right` (go-gitea#37291) Update Nix flake (go-gitea#37284) Workflow Artifact Info Hover (go-gitea#37100) [skip ci] Updated translations via Crowdin release notes for 1.26.0 (go-gitea#37282) Enhance GetActionWorkflow to support fallback references (go-gitea#37189) Refactor LDAP tests (go-gitea#37274) Remove `SubmitEvent` polyfill (go-gitea#37276) Upgrade go-git to v5.18.0 (go-gitea#37268) Avoid top-level await (go-gitea#37272) Frontend iframe renderer framework: 3D models, OpenAPI (go-gitea#37233) pull: Fix CODEOWNERS absolute path matching. (go-gitea#37244) Swift registry metadata: preserve more JSON fields and accept empty metadata (go-gitea#37254) ...

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 3, 2026

github-actions Bot added modifies/go labels Apr 3, 2026

bircni changed the title ~~restart~~ Workflow Artifact Info Hover Apr 3, 2026

bircni force-pushed the feature/add-artifact-expiry-hover branch from aee7bce to 9c7e067 Compare April 3, 2026 21:51

Add artifact expiry feature with tooltip and localization support

5d9a44e

bircni force-pushed the feature/add-artifact-expiry-hover branch from 9c7e067 to 5d9a44e Compare April 3, 2026 21:53

silverwind reviewed Apr 3, 2026

View reviewed changes

Comment thread options/locale/locale_en-US.json Outdated

fixes

7759b8d

Merge branch 'main' into feature/add-artifact-expiry-hover

96d62cf

bircni requested a review from silverwind April 6, 2026 10:26

silverwind and others added 2 commits April 9, 2026 21:01

Merge branch 'main' into feature/add-artifact-expiry-hover

415044d

Improve artifact link click area and tooltip spacing

06ba537

Move vertical padding from li to first-child so the link covers the full row height. Reduce tooltip offset to 2px. Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

silverwind requested a review from Copilot April 9, 2026 20:19

silverwind added the backport/v1.26 This PR should be backported to Gitea 1.26 label Apr 9, 2026

Copilot started reviewing on behalf of silverwind April 9, 2026 20:22 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

silverwind and others added 3 commits April 9, 2026 22:31

Encode artifact name in download URL, use 2-digit minutes

83f0d17

- encodeURIComponent on artifact download href for names with spaces or special characters - Use minute='2-digit' on relative-time for consistent zero-padding Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

Update devtest relative-time to use minute=2-digit

322023f

Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

silverwind force-pushed the feature/add-artifact-expiry-hover branch from b6c8792 to 3887aaf Compare April 9, 2026 20:44

Simplify formatBytes

840ca21

Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 18, 2026

fix

1e42ce6

wxiaoguang force-pushed the feature/add-artifact-expiry-hover branch from 54f23d1 to 1e42ce6 Compare April 19, 2026 05:40

fix test

45c1693

wxiaoguang approved these changes Apr 19, 2026

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 19, 2026

cover one more edge case

7d7a2aa

wxiaoguang added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 19, 2026

Merge branch 'main' into feature/add-artifact-expiry-hover

33c16a8

wxiaoguang enabled auto-merge (squash) April 19, 2026 07:15

wxiaoguang merged commit 16bdae5 into go-gitea:main Apr 19, 2026
26 checks passed

GiteaBot added this to the 1.27.0 milestone Apr 19, 2026

GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 19, 2026

bircni deleted the feature/add-artifact-expiry-hover branch April 19, 2026 10:12

silverwind reviewed Apr 19, 2026

View reviewed changes

Uh oh!

Conversation

bircni commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silverwind commented Apr 3, 2026

Uh oh!

Uh oh!

bircni commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silverwind commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silverwind commented Apr 9, 2026

Uh oh!

silverwind commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wxiaoguang commented Apr 19, 2026

Uh oh!

wxiaoguang commented Apr 19, 2026

Uh oh!

bircni commented Apr 19, 2026

Uh oh!

Uh oh!

silverwind commented Apr 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wxiaoguang commented Apr 19, 2026

Uh oh!

wxiaoguang commented Apr 19, 2026

Uh oh!

silverwind Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

wxiaoguang Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

silverwind Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

silverwind commented Apr 19, 2026

Uh oh!

wxiaoguang commented Apr 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wxiaoguang commented Apr 19, 2026

Uh oh!

silverwind commented Apr 19, 2026

Uh oh!

wxiaoguang commented Apr 19, 2026

Uh oh!

silverwind commented Apr 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bircni commented Apr 3, 2026 •

edited

Loading

bircni commented Apr 4, 2026 •

edited

Loading

silverwind commented Apr 4, 2026 •

edited

Loading

silverwind commented Apr 9, 2026 •

edited

Loading

silverwind commented Apr 19, 2026 •

edited

Loading

wxiaoguang commented Apr 19, 2026 •

edited

Loading