Skip to content

Update go js dependencies#37312

Merged
silverwind merged 7 commits intogo-gitea:mainfrom
sebastianertz:deps
Apr 20, 2026
Merged

Update go js dependencies#37312
silverwind merged 7 commits intogo-gitea:mainfrom
sebastianertz:deps

Conversation

@sebastianertz
Copy link
Copy Markdown
Contributor

@sebastianertz sebastianertz commented Apr 20, 2026 •
edited by silverwind
Loading

go from to
github.com/aws/aws-sdk-go-v2/credentials 1.19.14 1.19.15
github.com/aws/aws-sdk-go-v2/service/codecommit 1.33.12 1.33.13
github.com/dlclark/regexp2 1.11.5 1.12.0
github.com/go-co-op/gocron/v2 2.20.0 2.21.0
github.com/go-webauthn/webauthn 0.16.4 0.16.5
js from to
@codemirror/view 6.41.0 6.41.1
@primer/octicons 19.24.0 19.24.1
clippie 4.1.10 4.1.14
postcss 8.5.9 8.5.10
rolldown-license-plugin 2.2.5 3.0.1
swagger-ui-dist 5.32.2 5.32.4
vite 8.0.8 8.0.9
@typescript-eslint/parser 8.58.2 8.59.0
@vitest/eslint-plugin 1.6.15 1.6.16
eslint 10.2.0 10.2.1
eslint-plugin-playwright 2.10.1 2.10.2
eslint-plugin-sonarjs 4.0.2 4.0.3
happy-dom 20.8.9 20.9.0
stylelint 17.7.0 17.8.0
typescript 6.0.2 6.0.3
typescript-eslint 8.58.2 8.59.0
updates 17.15.3 17.15.5
vue-tsc 3.2.6 3.2.7

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 20, 2026
@sebastianertz sebastianertz marked this pull request as draft April 20, 2026 09:06
@silverwind
Copy link
Copy Markdown
Member

silverwind commented Apr 20, 2026

Related: go-co-op/gocron@2e69a26

Should check whether it makes more sense to use start or completion time.

sebastianertz
sebastianertz commented Apr 20, 2026
View reviewed changes
Comment thread services/cron/cron.go
@silverwind
Copy link
Copy Markdown
Member

silverwind commented Apr 20, 2026 •
edited
Loading

This "WebKit encountered an internal error" may be a pre-existing flake, webkit was added very recently in 6f76121, it only ran a few times on CI so far. If it's not stable, we ought to remove it again.

@sebastianertz sebastianertz marked this pull request as ready for review April 20, 2026 10:46
silverwind
silverwind approved these changes Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Webkit flake is unrelated.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 20, 2026
@silverwind
Copy link
Copy Markdown
Member

silverwind commented Apr 20, 2026

FYI webkit revert will be in #37315, it's just not stable on Linux.

@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Apr 20, 2026
@lunny lunny added this to the 1.27.0 milestone Apr 20, 2026
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 20, 2026
@silverwind
Copy link
Copy Markdown
Member

silverwind commented Apr 20, 2026

@sebastianertz there are indentation errors introduces in the pnpm lockfile. Which version of pnpm was used to generate it? Did you manually edit it?

transitivePeerDependencies:
- encoding # 2 spaces missing in front

@silverwind
Copy link
Copy Markdown
Member

silverwind commented Apr 20, 2026 •
edited
Loading

I've ran make update-js using pnpm 10.33.0 on MacOS in 420239e, should work now.

@silverwind @claude
Fix lint-js errors from new typescript-eslint rule
49d5991 
New `@typescript-eslint/no-unnecessary-type-assertion` reports flagged
casts that typescript-eslint now considers redundant. `eslint --fix`
removes them blindly and breaks `vue-tsc`, so restructure the code to
satisfy both:

- admin/config.test.ts: annotate `keys`/`values` as `string[]` so the
  `value as string` narrowing is needed (File is excluded from
  FormDataEntryValue).
- tribute.ts: move the `TributeCollection<any>` cast from individual
  items to the collection array.
- dropdown.ts, relative-time.ts: drop casts that were genuinely no-ops.

Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
@silverwind
Copy link
Copy Markdown
Member

silverwind commented Apr 20, 2026 •
edited
Loading

New js lint issues fix in 49d5991, these came from the typescript-eslint upgrade I did earlier. No runtime changes.

@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 20, 2026
@silverwind silverwind enabled auto-merge (squash) April 20, 2026 22:02
@silverwind silverwind merged commit 3f3bebd into go-gitea:main Apr 20, 2026
26 checks passed
silverwind added a commit to silverwind/gitea that referenced this pull request Apr 20, 2026
@silverwind
Merge remote-tracking branch 'origin/main' into relative-time-invalid…
03ebb69 
…-lang

* origin/main:
  Update go js dependencies (go-gitea#37312)
  Update GitHub Actions to latest major versions (go-gitea#37313)
  Revert "Add WebKit to e2e test matrix (go-gitea#37298)" (go-gitea#37315)
  Add `form-fetch-action` to some forms, fix "fetch action" resp bug (go-gitea#37305)
  Move heatmap to first-party code (go-gitea#37262)
  Use updated yaml fields for snapcraft (go-gitea#37318)
  Remove dead code identified by `deadcode` tool (go-gitea#37271)
  Enable strict TypeScript, add `errorMessage` helper (go-gitea#37292)
  Fix vite manifest update masking build errors (go-gitea#37279)
  bump snapcraft base (go-gitea#37301)

# Conflicts:
#	web_src/js/modules/errors.ts
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 20, 2026
@sebastianertz sebastianertz deleted the deps branch April 21, 2026 04:11
silverwind added a commit to 6543-forks/gitea that referenced this pull request Apr 21, 2026
@silverwind
Merge remote-tracking branch 'origin/main' into ux-package-deb-explai…
4d4ddf7 
…n-better

* origin/main: (645 commits)
  When the requested arch rpm is missing fall back to noarch (go-gitea#37236)
  Fix `relative-time` error and improve global error handler (go-gitea#37241)
  Enhance styling in actions page (go-gitea#37323)
  fix(oauth): Error on auth sources with spaces (go-gitea#37327)
  Fix actions concurrency groups cross-branch leak (go-gitea#37311)
  Fix bug when accessing user badges (go-gitea#37321)
  Fix AppFullLink (go-gitea#37325)
  Update go js dependencies (go-gitea#37312)
  Update GitHub Actions to latest major versions (go-gitea#37313)
  Revert "Add WebKit to e2e test matrix (go-gitea#37298)" (go-gitea#37315)
  Add `form-fetch-action` to some forms, fix "fetch action" resp bug (go-gitea#37305)
  Move heatmap to first-party code (go-gitea#37262)
  Use updated yaml fields for snapcraft (go-gitea#37318)
  Remove dead code identified by `deadcode` tool (go-gitea#37271)
  Enable strict TypeScript, add `errorMessage` helper (go-gitea#37292)
  Fix vite manifest update masking build errors (go-gitea#37279)
  bump snapcraft base (go-gitea#37301)
  Add WebKit to e2e test matrix (go-gitea#37298)
  Don't add useless labels which will bother changelog generation (go-gitea#37267)
  Fix Repository transferring page (go-gitea#37277)
  ...

# Conflicts:
#	options/locale/locale_en-US.ini
#	templates/package/content/debian.tmpl
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 22, 2026
@zjjhot
Merge branch 'main' into mainzjj
bfef37f 
* main: (25 commits)
  Add URL to `Learn more about blocking a user` (go-gitea#37355)
  fix: use TriggerEvent instead of Event in workflow runs API response for scheduled runs (go-gitea#37288)
  Add event.schedule context for schedule actions task (go-gitea#37320)
  Fix typos (go-gitea#37346)
  Fix an issue where changing an organization’s visibility caused problems when users had forked its repositories. (go-gitea#37324)
  Fail vite build on rolldown warnings via NODE_ENV=test (go-gitea#37270)
  Use modern "git update-index --cacheinfo" syntax to support more file names (go-gitea#37338)
  Fix URL related escaping for oauth2 (go-gitea#37334)
  When the requested arch rpm is missing fall back to noarch (go-gitea#37236)
  Fix `relative-time` error and improve global error handler (go-gitea#37241)
  Enhance styling in actions page (go-gitea#37323)
  fix(oauth): Error on auth sources with spaces (go-gitea#37327)
  Fix actions concurrency groups cross-branch leak (go-gitea#37311)
  Fix bug when accessing user badges (go-gitea#37321)
  Fix AppFullLink (go-gitea#37325)
  Update go js dependencies (go-gitea#37312)
  Update GitHub Actions to latest major versions (go-gitea#37313)
  Revert "Add WebKit to e2e test matrix (go-gitea#37298)" (go-gitea#37315)
  Add `form-fetch-action` to some forms, fix "fetch action" resp bug (go-gitea#37305)
  Move heatmap to first-party code (go-gitea#37262)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile

Projects

None yet

Milestone

1.27.0

Development

Successfully merging this pull request may close these issues.

5 participants

@sebastianertz @silverwind @lunny @GiteaBot @bircni