Refactor LDAP tests

[wxiaoguang]

Not really fix #37263, just make things better, and easy to catch more clues if it would fail again.

[wxiaoguang]

[Copilot]

Pull request overview

Refactors the LDAP integration tests to reduce reliance on an external LDAP server by splitting scenarios into subtests and using mocks where possible, while also adjusting a few related test/helpers and admin auth-source editing behavior.

Changes:

• Consolidates LDAP integration tests under TestAuthLDAP and gates real-LDAP-server scenarios behind TEST_LDAP.
• Refactors HTML test helper to accept an io.Reader and improves unexpected-response logging to ignore hidden flash errors.
• Removes AuthenticationForm.ID and redirects auth-source edit POSTs using the persisted source.ID instead.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/integration/integration_test.go	Avoids logging hidden flash error messages when diagnosing unexpected responses.
tests/integration/html_helper.go	Generalizes NewHTMLParser to accept any io.Reader.
tests/integration/auth_ldap_test.go	Restructures LDAP tests into subtests; adds mock-based email sign-in test and adds edit-or-create auth source helper.
services/forms/auth_form.go	Removes unused AuthenticationForm.ID field.
routers/web/admin/auths.go	Redirects after updating an auth source using source.ID instead of form-bound ID.
modules/testlogger/testlogger.go	Renames internal stdout printf helper and updates call sites.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[silverwind]

Added Fixes labels, assuming it's related to that issue.

[wxiaoguang]

It doesn't make any known fix for the reported issue (btw: the issue can be closed by this, until the error happens again)

Either:

• For unknown reason, the PR happens to have the issue fixed: good
• The issue is still not fixed: this PR will output more details to let developers know why it fails: good
  • The logic is still the same as before: load the page, parse DOM, get the link

	hrefAuthSource, exists := doc.Find("table.table td a").Attr("href")
	if !assert.True(t, exists, "No authentication source found") {
		t.Logf("response: %s", respStr)
		return
	}

[silverwind]

Removed the references then. If the failure is not reliably reproducible, we can't be sure whether any fix is right.

[wxiaoguang]

Removed the references then. If the failure is not reliably reproducible, we can't be sure whether any fix is right.

I don't see it's worth to keep the issue open. In recent years, it only happened once.

And even if it would happen next time, the code / stacktrace have hugely changed, the issue won't provide any useful information.

The issue should be closed.

[bircni]

Removed the references then. If the failure is not reliably reproducible, we can't be sure whether any fix is right.

I don't see it's worth to keep the issue open. In recent years, it only happened once.

And even if it would happen next time, the code / stacktrace have hugely changed, the issue won't provide any useful information.

The issue should be closed.

will close the issue and next time we have more for tracing

[silverwind]

yes close it, next time we have more context if it should ever fail again.