Rebase #1
Merged
Rebase #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update updtr to version 1.0.0 🚀
Update debug to version 2.6.8 🚀
Update enzyme to version 2.8.2 🚀
Update mocha to version 3.4.2 🚀
Update express to version 4.15.3 🚀
Update morgan to version 1.8.2 🚀
Update proxyquire to version 1.8.0 🚀
Update sinon to version 2.3.2 🚀
Keystone 4 Docs
Fix for views location default
packages.js generates a Uncaught SyntaxError: Unexpected string when minified, and fails to load the admin interface. After some digging I found that uglifyjs compresses the typeof checks into the following format "undefined"==typeof x which triggers a syntax error after passing through another minification process when deployed. A way to prevent this from happening is to allow semicolons in the uglifyjs command. Also needed to add the 'aphrodite/no-important' to the required packages for the Admin UI.
Fix Travis CI Build
Update maxAge of cookie to reflect time in milliseconds
Make file field a link when it has a href
…idation Expose password validation
Use safeRequire instead of manual try-catch requires
fix:typo in handleError in screens/Item/index.js
It was working before but the `./` was extraneous and redundant.
fix:module-name in import statement in EditForm.js
…-admin Cloudinary admin url update: fixes #2724
add alt text to delete button
underscore instead of undercore
Link is broken without `http://`
Update Underscore-Methods.md
Update options.md
Fixed incorrectly named API method label (fixes #4825)
By copying and pasting the site, I realized that the list was previously referenced with an uppercase.
Added toMoment method to allow Moment.js to use utc dates. Updated getValue to use toMoment for proper output.
Probably forgot to update part of readme from the older release "4.0.0.rc.1"
The sentence "Once you retrieve a list from Keystone, the mongoose methods can be accessed from." seemed incomplete
* Return a 500 error when `item.remove` fails Currently, errors from `item.remove` are not handled at all in the callback. This gives an empty 200 back to the frontend, which will do nothing with this response (no visual feedback on the error). We should return an actual error. All suggestions on how to return this error Keystone style are welcome. * directly send the `err` to `apiError`
* Restore/repair S3 image uploading in tinymce * Use custom root for S3 paths * Build S3 upload name when not present
The `auto update` field was highlighted incorrectly.
* add thumb option support to url type * do not fix the height of form input since it the value can be out of bound
ghbolivar
added a commit
that referenced
this pull request
Feb 24, 2019
This reverts commit 8313dfa.
Merged
ghbolivar
added a commit
that referenced
this pull request
Feb 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Related issues (if any)
Testing
npm run test-allran successfully.