Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add alt text to delete button #4813

Merged
merged 2 commits into from
Oct 5, 2018
Merged

add alt text to delete button #4813

merged 2 commits into from
Oct 5, 2018

Conversation

jimulle
Copy link
Contributor

@jimulle jimulle commented Oct 2, 2018 •
edited by autoboxer
Loading

Description of changes

Adds alt text "delete" to delete item button

Related issues (if any)

fixes #4717

Testing

  • List browser version(s) any admin UI changes were tested in:
  • Please confirm you've added (or verified) test coverage for this change.
  • Please confirm npm run test-all ran successfully.

autoboxer
autoboxer approved these changes Oct 4, 2018
View reviewed changes
Copy link
Contributor

@autoboxer autoboxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks @jimulle!

@autoboxer autoboxer merged commit d263dbd into keystonejs:master Oct 5, 2018
@stennie stennie added this to the 4.0.1 milestone Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@autoboxer autoboxer autoboxer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.1
Development

Successfully merging this pull request may close these issues.

Add «Alt» ou tooltip to trash Icon (delete action) for accessibility
3 participants
@jimulle @autoboxer @stennie