Cloudinary admin url update: fixes #2724 #4175
Conversation
Changes: Cloudinary fields pass down `secure` property with their `getOptions` call. When a url is created, the secure property is added.
Noviny
changed the title
|
Does |
|
@sktt secure does mean over https, and it was a legacy implementation we are working on moving away from. |
|
Any word on this being merged? |
| this._originalGetOptions(); | ||
| // We are performing the check here, so that if cloudinary secure is added | ||
| // to keystone after the model is registered, it will still be respected. | ||
| // Setting secure overrides default `cloudinary secure` |
There was a problem hiding this comment.
You've got me curious. What's the use case for setting secure/cloudinary secure after the models have been registered?
There was a problem hiding this comment.
It's mostly about the ordering of your keystone.js file. It is possible and valid to import your models and then after that line set cloudinary secure, however rather obtusely without checking again, you can end up not applying the option it looks like you set.
There was a problem hiding this comment.
I see. Thanks for the explanation.
Changes:
Cloudinary fields pass down
secureproperty with theirgetOptionscall.
When a url is created by the admin UI, the secure property is added. This is handled at each location an image is referenced.