Make file field a link when it has a href #4174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes keystonejs/keystone#4055 |
- File may not have a href if url flag is not set in its schema
sktt
force-pushed
the
bugfix/FileFieldLink
branch
from
24fbedf to
ca4cf13
Compare
|
@sktt Nice simple fix, thanks for this! |
|
wooop nice to see u in action, @Noviny, I thought all members where long gone : D |
|
Nup, we're still here =D We're going to get a new beta out on Monday as well. Watch this space! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have specified
schema: { url: true }in your storage adapter, admin ui will now make the span into a link. If not, then it will just be a span like before.Cheers