Fix Travis CI Build #4433
Merged
Fix Travis CI Build #4433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @christroutner. Can you remove the bits which change the notification section, please? The emails should still go to Jed and we still want slack notifications. |
|
Good catch @jstockwin. Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
I am submitting the PR at the request of @jstockwin. The Travis CI build has broken because Yarn no longer supports Node v0.12. The changes in this PR comment out the v0.12 tests, and get the Travis build to pass.
Related issues (if any)
Testing
npm run test-allran successfully.